Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2282)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 151283006: Mac OS X: Show the Translate icon on Omnibox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue-307352-translate-bubble-2
Patch Set: Nico's review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index cddca0ecf9838acc947a8625373a9cb033c75b45..c62e725637e9f16dc3f80ed02a8b5b213e29648c 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -64,6 +64,7 @@
#import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
#import "chrome/browser/ui/cocoa/tabs/tab_view.h"
#import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
+#import "chrome/browser/ui/cocoa/translate/translate_bubble_controller.h"
#include "chrome/browser/ui/fullscreen/fullscreen_controller.h"
#include "chrome/browser/ui/omnibox/location_bar.h"
#include "chrome/browser/ui/tabs/dock_info.h"
@@ -1247,6 +1248,10 @@ enum {
[toolbarController_ setStarredState:isStarred];
}
+- (void)setCurrentPageIsTranslated:(BOOL)on {
+ [toolbarController_ setTranslateIconLit:on];
+}
+
- (void)zoomChangedForActiveTab:(BOOL)canShowBubble {
[toolbarController_ zoomChangedForActiveTab:canShowBubble];
}
@@ -1679,6 +1684,16 @@ enum {
}
}
+- (void)showTranslateBubbleForWebContents:(content::WebContents*)contents
+ viewState:
+ (TranslateBubbleModel::ViewState)viewState
+ errorType:(TranslateErrors::Type)errorType {
+ [TranslateBubbleController showBubbleWithBrowserWindowController:self
+ webContents:contents
+ viewState:viewState
+ errorType:errorType];
+}
+
// Nil out the weak bookmark bubble controller reference.
- (void)bookmarkBubbleWindowWillClose:(NSNotification*)notification {
DCHECK_EQ([notification object], [bookmarkBubbleController_ window]);

Powered by Google App Engine
This is Rietveld 408576698