third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp - Issue 1512803004: Use refs for GraphicsContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

Issue 1512803004: Use refs for GraphicsContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ScrollbarTheme

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ImageQualityController.h ('K') | « third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp ('k') | third_party/WebKit/Source/core/paint/SVGImagePainter.cpp » ('j') | third_party/WebKit/Source/core/paint/SVGPaintContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp b/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

index 592960e05d311fa14ec6b225d996ee9abc696887..f1db561bc15e612bee5ed54f6959dfb6723e249e 100644

--- a/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp

@@ -23,11 +23,11 @@ void SVGForeignObjectPainter::paint(const PaintInfo& paintInfo)

PaintInfo paintInfoBeforeFiltering(paintInfo);

paintInfoBeforeFiltering.updateCullRect(m_layoutSVGForeignObject.localTransform());

- TransformRecorder transformRecorder(*paintInfoBeforeFiltering.context, m_layoutSVGForeignObject, m_layoutSVGForeignObject.localTransform());

+ TransformRecorder transformRecorder(paintInfoBeforeFiltering.context, m_layoutSVGForeignObject, m_layoutSVGForeignObject.localTransform());

Optional<FloatClipRecorder> clipRecorder;

if (SVGLayoutSupport::isOverflowHidden(&m_layoutSVGForeignObject))

- clipRecorder.emplace(*paintInfoBeforeFiltering.context, m_layoutSVGForeignObject, paintInfoBeforeFiltering.phase, m_layoutSVGForeignObject.viewportRect());

+ clipRecorder.emplace(paintInfoBeforeFiltering.context, m_layoutSVGForeignObject, paintInfoBeforeFiltering.phase, m_layoutSVGForeignObject.viewportRect());

SVGPaintContext paintContext(m_layoutSVGForeignObject, paintInfoBeforeFiltering);

bool continueRendering = true;