core/src/fpdfdoc/doc_annot.cpp - Issue 1512763013: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_annot.cpp

Issue 1512763013: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfdoc/doc_annot.cpp

diff --git a/core/src/fpdfdoc/doc_annot.cpp b/core/src/fpdfdoc/doc_annot.cpp

index cacd650dde99edf53aecd4b484752176f846b075..0871b357cf69970d2d7e85087f8d1db916dc0fb0 100644

--- a/core/src/fpdfdoc/doc_annot.cpp

+++ b/core/src/fpdfdoc/doc_annot.cpp

@@ -304,7 +304,7 @@ void CPDF_Annot::DrawBorder(CFX_RenderDevice* pDevice,

}

CPDF_Array* pColor = m_pAnnotDict->GetArray("C");

FX_DWORD argb = 0xff000000;

- if (pColor != NULL) {

+ if (pColor) {

int R = (int32_t)(pColor->GetNumber(0) * 255);

int G = (int32_t)(pColor->GetNumber(1) * 255);

int B = (int32_t)(pColor->GetNumber(2) * 255);

« no previous file with comments | « core/src/fpdfdoc/doc_action.cpp ('k') | core/src/fpdfdoc/doc_ap.cpp » ('j') | no next file with comments »