core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp - Issue 1512763013: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Issue 1512763013: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

index 52129d9e545cea285406f5f5a66d6fa4c018263c..a797332727000c1a367f462fe24f46c678cdea78 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

@@ -1433,8 +1433,8 @@ void CPDF_Creator::InitNewObjNumOffsets() {

FX_BOOL bNewStart = FALSE;

for (; i < iCount; i++) {

FX_DWORD dwCurObjNum = m_NewObjNumArray.ElementAt(i);

- FX_BOOL bExist = (dwCurObjNum < nOldSize &&

- m_ObjectOffset.GetPtrAt(dwCurObjNum) != NULL);

+ FX_BOOL bExist =

+ (dwCurObjNum < nOldSize && m_ObjectOffset.GetPtrAt(dwCurObjNum));

if (bExist || dwCurObjNum - dwLastObjNum > 1) {

if (!bNewStart) {

m_ObjectOffset.Add(dwStartObjNum, dwLastObjNum - dwStartObjNum + 1);