Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/src/pdfwindow/PWL_ListBox.cpp

Issue 1512763013: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/src/fsdk_baseform.cpp ('K') | « fpdfsdk/src/pdfwindow/PWL_Label.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Note.cpp » ('j') | fpdfsdk/src/pdfwindow/PWL_Note.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/pdfwindow/PWL_ListBox.cpp
diff --git a/fpdfsdk/src/pdfwindow/PWL_ListBox.cpp b/fpdfsdk/src/pdfwindow/PWL_ListBox.cpp
index 229c1dd81e94bfdcdd45b704fd5749c224c646e9..9290617f5f712b671ac8365d679d910a728e2e28 100644
--- a/fpdfsdk/src/pdfwindow/PWL_ListBox.cpp
+++ b/fpdfsdk/src/pdfwindow/PWL_ListBox.cpp
@@ -20,7 +20,7 @@
/* ------------------------ CPWL_List_Notify ----------------------- */
CPWL_List_Notify::CPWL_List_Notify(CPWL_ListBox* pList) : m_pList(pList) {
- ASSERT(m_pList != NULL);
+ ASSERT(m_pList);
}
CPWL_List_Notify::~CPWL_List_Notify() {}
@@ -74,8 +74,7 @@ CPWL_ListBox::CPWL_ListBox()
m_bHoverSel(FALSE),
m_pFillerNotify(NULL) {
m_pList = IFX_List::NewList();
-
- ASSERT(m_pList != NULL);
+ ASSERT(m_pList);
Tom Sepez 2015/12/14 19:14:12 Nit: can this fail?
Lei Zhang 2015/12/15 01:38:33 No, removed.
}
CPWL_ListBox::~CPWL_ListBox() {
« fpdfsdk/src/fsdk_baseform.cpp ('K') | « fpdfsdk/src/pdfwindow/PWL_Label.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Note.cpp » ('j') | fpdfsdk/src/pdfwindow/PWL_Note.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698