Get rid of most instance of 'foo != NULL'

core/src/fxcrt/fx_basic_wstring.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <stddef.h>  // For offsetof().
 #include <cctype>
 
 #include "core/include/fxcrt/fx_basic.h"
@@ skipping 240 matching lines @@
   pOldData->Release();
 }
 void CFX_WideString::CopyBeforeWrite() {
   if (m_pData == NULL || m_pData->m_nRefs <= 1) {
     return;
   }
   StringData* pData = m_pData;
   m_pData->Release();
   FX_STRSIZE nDataLength = pData->m_nDataLength;
   m_pData = StringData::Create(nDataLength);
-  if (m_pData != NULL) {
+  if (m_pData) {
     FXSYS_memcpy(m_pData->m_String, pData->m_String,
                  (nDataLength + 1) * sizeof(FX_WCHAR));
   }
 }
 void CFX_WideString::AllocBeforeWrite(FX_STRSIZE nLen) {
   if (m_pData && m_pData->m_nRefs <= 1 && m_pData->m_nAllocLength >= nLen) {
     return;
   }
   Empty();
   m_pData = StringData::Create(nLen);
@@ skipping 261 matching lines @@
     return -1;
   }
   FX_STRSIZE nLength = m_pData->m_nDataLength;
   if (nStart >= nLength) {
     return -1;
   }
   const FX_WCHAR* lpsz = FXSYS_wcschr(m_pData->m_String + nStart, ch);
   return (lpsz == NULL) ? -1 : (int)(lpsz - m_pData->m_String);
 }
 void CFX_WideString::TrimRight(const FX_WCHAR* lpszTargetList) {
-  FXSYS_assert(lpszTargetList != NULL);
+  FXSYS_assert(lpszTargetList);
   if (m_pData == NULL || *lpszTargetList == 0) {
     return;
   }
   CopyBeforeWrite();
   FX_STRSIZE len = GetLength();
   if (len < 1) {
     return;
   }
   FX_STRSIZE pos = len;
   while (pos) {
     if (FXSYS_wcschr(lpszTargetList, m_pData->m_String[pos - 1]) == NULL) {
       break;
     }
     pos--;
   }
   if (pos < len) {
     m_pData->m_String[pos] = 0;
     m_pData->m_nDataLength = pos;
   }
 }
 void CFX_WideString::TrimRight(FX_WCHAR chTarget) {
   FX_WCHAR str[2] = {chTarget, 0};
   TrimRight(str);
 }
 void CFX_WideString::TrimRight() {
   TrimRight(L"\x09\x0a\x0b\x0c\x0d\x20");
 }
 void CFX_WideString::TrimLeft(const FX_WCHAR* lpszTargets) {
-  FXSYS_assert(lpszTargets != NULL);
+  FXSYS_assert(lpszTargets);
   if (m_pData == NULL || *lpszTargets == 0) {
     return;
   }
   CopyBeforeWrite();
   if (GetLength() < 1) {
     return;
   }
   const FX_WCHAR* lpsz = m_pData->m_String;
   while (*lpsz != 0) {
     if (FXSYS_wcschr(lpszTargets, *lpsz) == NULL) {
@@ skipping 27 matching lines @@
   FX_STRSIZE nSourceLen = FXSYS_wcslen(lpszOld);
   if (nSourceLen == 0) {
     return 0;
   }
   FX_STRSIZE nReplacementLen = lpszNew ? FXSYS_wcslen(lpszNew) : 0;
   FX_STRSIZE nCount = 0;
   FX_WCHAR* lpszStart = m_pData->m_String;
   FX_WCHAR* lpszEnd = m_pData->m_String + m_pData->m_nDataLength;
   FX_WCHAR* lpszTarget;
   {
-    while ((lpszTarget = (FX_WCHAR*)FXSYS_wcsstr(lpszStart, lpszOld)) != NULL &&
+    while ((lpszTarget = (FX_WCHAR*)FXSYS_wcsstr(lpszStart, lpszOld)) &&
            lpszStart < lpszEnd) {
       nCount++;
       lpszStart = lpszTarget + nSourceLen;
     }
   }
   if (nCount > 0) {
     CopyBeforeWrite();
     FX_STRSIZE nOldLength = m_pData->m_nDataLength;
     FX_STRSIZE nNewLength =
         nOldLength + (nReplacementLen - nSourceLen) * nCount;
@@ skipping 40 matching lines @@
     nIndex = nNewLength;
   }
   nNewLength++;
   if (m_pData == NULL || m_pData->m_nAllocLength < nNewLength) {
     StringData* pOldData = m_pData;
     const FX_WCHAR* pstr = m_pData->m_String;
     m_pData = StringData::Create(nNewLength);
     if (!m_pData) {
       return 0;
     }
-    if (pOldData != NULL) {
+    if (pOldData) {
       FXSYS_memmove(m_pData->m_String, pstr,
                     (pOldData->m_nDataLength + 1) * sizeof(FX_WCHAR));
       pOldData->Release();
     } else {
       m_pData->m_String[0] = 0;
     }
   }
   FXSYS_memmove(m_pData->m_String + nIndex + 1, m_pData->m_String + nIndex,
                 (nNewLength - nIndex) * sizeof(FX_WCHAR));
   m_pData->m_String[nIndex] = ch;
@@ skipping 367 matching lines @@
       return (CFX_CharMap*)&g_DefaultJISMapper;
     case 936:
       return (CFX_CharMap*)&g_DefaultGBKMapper;
     case 949:
       return (CFX_CharMap*)&g_DefaultUHCMapper;
     case 950:
       return (CFX_CharMap*)&g_DefaultBig5Mapper;
   }
   return NULL;
 }