Get rid of most instance of 'foo != NULL'

core/src/fpdfapi/fpdf_render/fpdf_render.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "render_int.h"
 
 #include "core/include/fpdfapi/fpdf_module.h"
 #include "core/include/fpdfapi/fpdf_render.h"
@@ skipping 525 matching lines @@
   }
   CFX_GraphStateData graphState(*pPathObj->m_GraphState);
   if (m_Options.m_Flags & RENDER_THINLINE) {
     graphState.m_LineWidth = 0;
   }
   return m_pDevice->DrawPath(pPathObj->m_Path, &path_matrix, &graphState,
                              fill_argb, stroke_argb, FillType, 0, NULL,
                              m_curBlend);
 }
 CPDF_TransferFunc* CPDF_RenderStatus::GetTransferFunc(CPDF_Object* pObj) const {
-  ASSERT(pObj != NULL);
+  ASSERT(pObj);
   CPDF_DocRenderData* pDocCache = m_pContext->m_pDocument->GetRenderData();
   if (!pDocCache) {

[Tom Sepez, 2015/12/14 19:14:08]

nit: use ? oper.

[Lei Zhang, 2015/12/15 01:38:32]

Done.

     return NULL;
   }
   return pDocCache->GetTransferFunc(pObj);
 }
 FX_ARGB CPDF_RenderStatus::GetFillArgb(const CPDF_PageObject* pObj,
                                        FX_BOOL bType3) const {
   CPDF_ColorStateData* pColorData =
       (CPDF_ColorStateData*)(const CPDF_ColorStateData*)pObj->m_ColorState;
   if (m_pType3Char && !bType3 &&
       (!m_pType3Char->m_bColored ||
@@ skipping 789 matching lines @@
 
 CPDF_ScaledRenderBuffer::~CPDF_ScaledRenderBuffer() {}
 
 #define _FPDFAPI_IMAGESIZE_LIMIT_ (30 * 1024 * 1024)
 FX_BOOL CPDF_ScaledRenderBuffer::Initialize(CPDF_RenderContext* pContext,
                                             CFX_RenderDevice* pDevice,
                                             FX_RECT* pRect,
                                             const CPDF_PageObject* pObj,
                                             const CPDF_RenderOptions* pOptions,
                                             int max_dpi) {
-  FXSYS_assert(pRect != NULL);
+  FXSYS_assert(pRect);

[Tom Sepez, 2015/12/14 21:10:27]

meh. Only called in one place with pRect as &local, change to pass by const ref
instead?

[Lei Zhang, 2015/12/15 01:38:32]

Done.

   m_pDevice = pDevice;
   if (m_pDevice->GetDeviceCaps(FXDC_RENDER_CAPS) & FXRC_GET_BITS) {
     return TRUE;
   }
   m_pContext = pContext;
   m_Rect = *pRect;
   m_pObject = pObj;
   m_Matrix.TranslateI(-pRect->left, -pRect->top);
   int horz_size = pDevice->GetDeviceCaps(FXDC_HORZ_SIZE);
   int vert_size = pDevice->GetDeviceCaps(FXDC_VERT_SIZE);
@@ skipping 53 matching lines @@
         item.GetParamType() == CPDF_ContentMarkItem::PropertiesDict) {
       CPDF_Dictionary* pOCG =
           ToDictionary(static_cast<CPDF_Object*>(item.GetParam()));
       if (!CheckOCGVisible(pOCG)) {
         return FALSE;
       }
     }
   }
   return TRUE;
 }