Get rid of most instance of 'foo != NULL'

core/src/fpdfapi/fpdf_font/ttgsubtable.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_SRC_FPDFAPI_FPDF_FONT_TTGSUBTABLE_H_
 #define CORE_SRC_FPDFAPI_FPDF_FONT_TTGSUBTABLE_H_
 
 #include <stdint.h>
@@ skipping 259 matching lines @@
     TSingleSubstFormat2& operator=(const TSingleSubstFormat2&);
   };
   struct TLookup {
     uint16_t LookupType;
     uint16_t LookupFlag;
     uint16_t SubTableCount;
     struct TSubTableBase** SubTable;
     TLookup()
         : LookupType(0), LookupFlag(0), SubTableCount(0), SubTable(NULL) {}
     ~TLookup() {
-      if (SubTableCount > 0 && SubTable != NULL) {
+      if (SubTableCount > 0 && SubTable) {

[Tom Sepez, 2015/12/14 19:14:07]

nit: could we write 
   if (SubTable && SubTableCount > 0)

I don't know why, but it reads much easier to me that way ...
And looking at this, I think its wrong, since we want to delete[] subtable even
if we have a subtablecout of 0?  And then the for loop guards deleting elts in
the 0 length case ... and ...  so

if (SubTable) {
  for (...)
    delete ...;
  delete ...;
}

[Lei Zhang, 2015/12/15 01:38:32]

Done.

         for (int i = 0; i < SubTableCount; i++) {
           delete SubTable[i];
         }
         delete[] SubTable;
       }
     }
 
    private:
     TLookup(const TLookup&);
     TLookup& operator=(const TLookup&);
@@ skipping 64 matching lines @@
 };
 class CFX_GSUBTable final : public IFX_GSUBTable {
  public:
   ~CFX_GSUBTable() override {}
   FX_BOOL GetVerticalGlyph(FX_DWORD glyphnum, FX_DWORD* vglyphnum) override;
 
   CFX_CTTGSUBTable m_GsubImp;
 };
 
 #endif  // CORE_SRC_FPDFAPI_FPDF_FONT_TTGSUBTABLE_H_