Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: ppapi/proxy/ppapi_messages.h

Issue 1512733003: PNaCl: Use Chrome IPC to talk to the linker process, instead of SRPC (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase + cleanup Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/proxy/nacl_message_scanner.cc ('K') | « ppapi/proxy/nacl_message_scanner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppapi_messages.h
diff --git a/ppapi/proxy/ppapi_messages.h b/ppapi/proxy/ppapi_messages.h
index 3bc0d5fe694fe275c3f1911f8070010850c7b8fd..dcde9d9dca9aaea37838d62b955cf5dc18c3621f 100644
--- a/ppapi/proxy/ppapi_messages.h
+++ b/ppapi/proxy/ppapi_messages.h
@@ -868,6 +868,18 @@ IPC_SYNC_MESSAGE_ROUTED1_1(PpapiMsg_PPPInstancePrivate_GetInstanceObject,
#endif // !defined(OS_NACL) && !defined(NACL_WIN64)
+// Calls the PNaCl linker process to link the given object files together
+// to produce a nexe file. Note that this PNaCl translation plumbing is
+// not part of PPAPI proper, but this message is defined here because it
+// needs to use the ppapi::proxy::SerializedHandle type.
bbudge 2015/12/16 20:30:06 Should this message be moved up close to the other
Mark Seaborn 2015/12/17 06:09:56 That's not quite the distinction I was making...
bbudge 2015/12/17 19:10:24 Whatever seems reasonable to you. See my other com
Mark Seaborn 2015/12/21 22:58:50 OK, I have removed the part mentioning "PPAPI prop
+IPC_SYNC_MESSAGE_CONTROL2_1(PpapiMsg_PnaclTranslatorLink,
+ /* object file FDs for inputs */
+ std::vector<ppapi::proxy::SerializedHandle>,
+ /* nexe file FD for output */
+ ppapi::proxy::SerializedHandle,
+ /* success status result */
+ bool)
+
// Reports to the browser that a plugin has been active.
IPC_MESSAGE_CONTROL0(PpapiHostMsg_Keepalive)
bbudge 2015/12/16 20:30:06 This also seems like an implementation detail mess
Mark Seaborn 2015/12/17 06:09:56 Hmm, I would regard all the IPC messages as implem
bbudge 2015/12/17 19:10:22 Right, by "implementation detail" I meant not used
Mark Seaborn 2015/12/21 22:58:50 I'm a bit reluctant to start using new prefixes be
bbudge 2015/12/21 23:28:51 OK, maybe I'm overthinking this. Your first idea s
@@ -885,6 +897,9 @@ IPC_MESSAGE_CONTROL1(PpapiHostMsg_ChannelCreated,
IPC_MESSAGE_CONTROL0(PpapiHostMsg_StartupInitializationComplete)
// Calls renderer to open a resource file for nacl_irt_open_resource().
+// Note that open_resource() is not part of PPAPI proper, but this message
+// is defined here because it needs to use the
+// ppapi::proxy::SerializedHandle type.
bbudge 2015/12/16 20:30:06 Related to my above comments, would it be clearer
Mark Seaborn 2015/12/17 06:09:56 PpapiHostMsg_OpenResource is actually usable by no
bbudge 2015/12/17 19:10:24 Hmm, the message name is kind of misleading given
Mark Seaborn 2015/12/21 22:58:50 OK, I'm dropping this comment change from this CL,
IPC_SYNC_MESSAGE_CONTROL1_3(PpapiHostMsg_OpenResource,
std::string /* key */,
ppapi::proxy::SerializedHandle /* fd */,
« ppapi/proxy/nacl_message_scanner.cc ('K') | « ppapi/proxy/nacl_message_scanner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698