components/nacl/renderer/plugin/temporary_file.cc - Issue 1512733003: PNaCl: Use Chrome IPC to talk to the linker process, instead of SRPC

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/renderer/plugin/temporary_file.cc

Issue 1512733003: PNaCl: Use Chrome IPC to talk to the linker process, instead of SRPC (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase + cleanup Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/nacl/renderer/plugin/temporary_file.h ('K') | « components/nacl/renderer/plugin/temporary_file.h ('k') | components/nacl/renderer/ppb_nacl_private.h » ('j') | ppapi/nacl_irt/irt_pnacl_translator_link.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/nacl/renderer/plugin/temporary_file.h"	5 #include "components/nacl/renderer/plugin/temporary_file.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "components/nacl/renderer/plugin/plugin.h"	8 #include "components/nacl/renderer/plugin/plugin.h"

9 #include "components/nacl/renderer/plugin/utility.h"	9 #include "components/nacl/renderer/plugin/utility.h"

10 #include "native_client/src/include/portability_io.h"	10 #include "native_client/src/include/portability_io.h"

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 // backed by the same file, so it should also reset.	57 // backed by the same file, so it should also reset.

58 CHECK(read_wrapper_);	58 CHECK(read_wrapper_);

59 nacl_off64_t newpos = read_wrapper_->Seek(0, SEEK_SET);	59 nacl_off64_t newpos = read_wrapper_->Seek(0, SEEK_SET);

60 return newpos == 0;	60 return newpos == 0;

61 }	61 }

62	62

63 PP_FileHandle TempFile::TakeFileHandle() {	63 PP_FileHandle TempFile::TakeFileHandle() {

64 return file_handle_.TakePlatformFile();	64 return file_handle_.TakePlatformFile();

65 }	65 }

66	66

	67 PP_FileHandle TempFile::GetFileHandle() {
	bbudge 2015/12/16 20:30:06 DCHECK(file_handle_.IsValid()); ? DCHECK(file_handle_.IsValid()); ? Mark Seaborn 2015/12/17 06:09:56 OK. How about I put the same into TakeFileHandle( Show quoted text On 2015/12/16 20:30:06, bbudge wrote: > DCHECK(file_handle_.IsValid()); ? OK. How about I put the same into TakeFileHandle() too for consistency? bbudge 2015/12/17 19:10:21 sgtm Show quoted text On 2015/12/17 06:09:56, Mark Seaborn wrote: > On 2015/12/16 20:30:06, bbudge wrote: > > DCHECK(file_handle_.IsValid()); ? > > OK. How about I put the same into TakeFileHandle() too for consistency? sgtm
	68 return file_handle_.GetPlatformFile();

	69 }

	70

67 } // namespace plugin	71 } // namespace plugin

OLD	NEW