Make filesystem objects ScriptWrappable.

Make filesystem objects ScriptWrappable.

This change allows binding integrity checks to be applied to these objects.

R=abarth@chromium.org
BUG=236671
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150361

[Tom Sepez, 2013-05-14 00:32:58]

abarth please review.

[abarth-chromium, 2013-05-14 00:38:13]

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
File Source/modules/filesystem/DOMFileSystem.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
Source/modules/filesystem/DOMFileSystem.h:47: class DOMFileSystem : public
DOMFileSystemBase, public ActiveDOMObject, public ScriptWrappable {
Usually we put ScriptWrappable next to the RefCounted base class.  Is that
hidden in DOMFileSystemBase?  Should the ScriptWrappable go there?

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
File Source/modules/filesystem/DOMFileSystemSync.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
Source/modules/filesystem/DOMFileSystemSync.h:46: class DOMFileSystemSync :
public DOMFileSystemBase, public ScriptWrappable {
here too

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
File Source/modules/filesystem/DOMWindowFileSystem.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
Source/modules/filesystem/DOMWindowFileSystem.h:40: class DOMWindowFileSystem :
public ScriptWrappable {
This doesn't make sense.  This object is never wrapped.

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Dir...
File Source/modules/filesystem/DirectoryReader.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Dir...
Source/modules/filesystem/DirectoryReader.h:47: class DirectoryReader : public
DirectoryReaderBase, public ScriptWrappable {
Same question here.

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Ent...
File Source/modules/filesystem/Entry.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Ent...
Source/modules/filesystem/Entry.h:49: class Entry : public ScriptWrappable,
public EntryBase {
Same here.  What the deal with these "base" objects?

[Tom Sepez, 2013-05-14 18:21:51]

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
File Source/modules/filesystem/DOMFileSystem.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
Source/modules/filesystem/DOMFileSystem.h:47: class DOMFileSystem : public
DOMFileSystemBase, public ActiveDOMObject, public ScriptWrappable {
On 2013/05/14 00:38:13, abarth wrote:
> Usually we put ScriptWrappable next to the RefCounted base class.  Is that
> hidden in DOMFileSystemBase?  Should the ScriptWrappable go there?
DOMFileSystemBase is the refcount'ed class.  But since there isn't a
DOMFileSytemBase.idl, I'm not comfortable about making it a ScriptWrappable --
as in calling ScriptWrappable::init() from a DOMFileSystemBase class won't work
because there isn't a matching wrapper via the idl generation. So I'll swap
ScriptWrappable and ActiveDOMObject.

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
File Source/modules/filesystem/DOMFileSystemSync.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
Source/modules/filesystem/DOMFileSystemSync.h:46: class DOMFileSystemSync :
public DOMFileSystemBase, public ScriptWrappable {
On 2013/05/14 00:38:13, abarth wrote:
> here too
See above.

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
File Source/modules/filesystem/DOMWindowFileSystem.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/DOM...
Source/modules/filesystem/DOMWindowFileSystem.h:40: class DOMWindowFileSystem :
public ScriptWrappable {
On 2013/05/14 00:38:13, abarth wrote:
> This doesn't make sense.  This object is never wrapped.
Ah.  I'd wondered about these where there are only static methods.  Will remove.

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Dir...
File Source/modules/filesystem/DirectoryReader.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Dir...
Source/modules/filesystem/DirectoryReader.h:47: class DirectoryReader : public
DirectoryReaderBase, public ScriptWrappable {
On 2013/05/14 00:38:13, abarth wrote:
> Same question here.
Answer above.  I think this is appropriate -- but do you want the wrappable in
front of the ref-counted class?

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Ent...
File Source/modules/filesystem/Entry.h (right):

https://codereview.chromium.org/15127005/diff/1/Source/modules/filesystem/Ent...
Source/modules/filesystem/Entry.h:49: class Entry : public ScriptWrappable,
public EntryBase {
On 2013/05/14 00:38:13, abarth wrote:
> Same here.  What the deal with these "base" objects?
Implementation details.  Not an interface, therefore the Base isn't really
wrappable in some sense.  Same question as before about whether the Wrappable
should come after the base class that is refcounted.  This is opposite the other
one -- I should at least be consistent once we pick a way.

[abarth-chromium, 2013-05-14 18:45:41]

Ok.  I think it makes sense to use ScriptWrappable only for object that can
actually be wrapped by script.  LGTM

[commit-bot: I haz the power, 2013-05-14 19:56:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/15127005/12001

[commit-bot: I haz the power, 2013-05-14 21:04:01]

Change committed as 150361