Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1512643002: Added default timeout to InstrumentedHttp (Closed)

Created:
5 years ago by pgervais
Modified:
5 years ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+infra_chromium.org, dsansome
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Added default timeout to InstrumentedHttp BUG= Committed: https://chromium.googlesource.com/infra/infra/+/637ea74ee47615fc471d592613d046ba0a5c3bd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M infra_libs/httplib2_utils.py View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pgervais
Generalizing https://codereview.chromium.org/1510753002/
5 years ago (2015-12-08 17:44:14 UTC) #2
Sergey Berezin
LGTM, thanks!
5 years ago (2015-12-08 18:51:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512643002/1
5 years ago (2015-12-08 18:52:36 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-08 18:56:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/637ea74ee47615fc471d592613d04...

Powered by Google App Engine
This is Rietveld 408576698