Move content property into CSSPropertyParser

Move content property into CSSPropertyParser

Move content property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
Committed: https://crrev.com/bdad68b726dd0c294f035e02d3836629ee5d144f
Cr-Commit-Position: refs/heads/master@{#365325}

[rwlbuis, 2015-12-14 23:55:51]

Patchset #7 (id:120001) has been deleted

[rwlbuis, 2015-12-15 03:47:05]

Description was changed from

==========
content WIP


Add support for <image> type parsing using CSSParserTokens

Add support for <image> type [1] parsing using CSSParserTokens
by introducing consumeImage.

To keep the size reasonable, this patch only covers crossfade, linear
and radial gradients.

BUG=499780

[1] https://drafts.csswg.org/css-images-3/#typedef-image

patch from issue 1508913002 at patchset 20001
(http://crrev.com/1508913002#ps20001)
==========

to

==========
Move content property into CSSPropertyParser

Move content property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2015-12-15 03:49:30]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-12-15 03:49:30]

PTAL. I was planning to wait until https://codereview.chromium.org/1512243005/
landed, but looks like the bots have some problem...

[Timothy Loh, 2015-12-15 04:44:54]

lgtm

https://codereview.chromium.org/1512603002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1512603002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2628: // But
HTML attribute names can't have those characters, and we should not
This comment seems wrong. The HTML spec doesn't seem to reject "-", and this
isn't mentioned anywhere. Firefox seems to allow any valid ident.
http://www.w3.org/TR/html5/syntax.html#attributes-0
http://www.w3.org/TR/CSS2/generate.html#x18

Maybe a TODO instead?
// TODO(timloh): We should allow any <ident-token> here.

https://codereview.chromium.org/1512603002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2647:
RefPtrWillBeRawPtr<CSSCustomIdentValue> separator = nullptr;
I guess I'll take a TODO here...

// TODO(timloh): Make this a CSSStringValue.

https://codereview.chromium.org/1512603002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2659: if
(args.atEnd()) { // Make the list style default decimal
How about (one less args.atEnd(), longest line isn't quite so long, not manually
creating ident for non-default case):

if (consumeComma..(args)) {
    CSSValueID id = args.peek().id();
    if (...)
        return nullptr;
    listStyle = consumeIdent(args);
} else {
    listStyle = ...(CSSValueDecimal);
}

if (!args.atEnd())
    return nullptr;
return ...

https://codereview.chromium.org/1512603002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2681: if
(!parsedValue)
I think it'd look nicer if these weren't nested -- might be a few extra cycles
but it shouldn't matter.

[rwlbuis, 2015-12-15 16:15:02]

Patchset #8 (id:160001) has been deleted

[rwlbuis, 2015-12-15 16:59:58]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-12-15 16:59:59]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1512603002/#ps180001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-12-15 17:00:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512603002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512603002/180001

[commit-bot: I haz the power, 2015-12-15 18:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 18:10:56]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[rwlbuis, 2015-12-15 18:33:20]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-12-15 18:35:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512603002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512603002/180001

[commit-bot: I haz the power, 2015-12-15 21:27:53]

Description was changed from

==========
Move content property into CSSPropertyParser

Move content property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move content property into CSSPropertyParser

Move content property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[commit-bot: I haz the power, 2015-12-15 21:27:53]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2015-12-15 21:29:12]

Description was changed from

==========
Move content property into CSSPropertyParser

Move content property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move content property into CSSPropertyParser

Move content property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780

Committed: https://crrev.com/bdad68b726dd0c294f035e02d3836629ee5d144f
Cr-Commit-Position: refs/heads/master@{#365325}
==========

[commit-bot: I haz the power, 2015-12-15 21:29:13]

Patchset 8 (id:??) landed as
https://crrev.com/bdad68b726dd0c294f035e02d3836629ee5d144f
Cr-Commit-Position: refs/heads/master@{#365325}