Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1512573002: Disallow const getters. (Closed)

Created:
5 years ago by Johnni Winther
Modified:
5 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M pkg/compiler/lib/src/parser/parser.dart View 4 chunks +9 lines, -1 line 0 comments Download
A + tests/language/const_getter_test.dart View 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
5 years ago (2015-12-08 12:50:26 UTC) #3
karlklose
LGTM.
5 years ago (2015-12-08 14:55:19 UTC) #4
Johnni Winther
5 years ago (2015-12-09 09:46:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
116a96bea504407755023b12e7f6c18a8edd6195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698