Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1512553002: [cctest] Move most heap related tests to test/cctest/heap and clean wrt IWYU (Closed)

Created:
5 years ago by Michael Lippautz
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cctest] Move most heap related tests to test/cctest/heap and clean wrt IWYU * Move most heap related tests into heap/ subdir * IWYU for heap utility functions R=ulan@chromium.org BUG= Committed: https://crrev.com/8ad016d361cae0f8aa2eb8ad4bfda69038d2a944 Cr-Commit-Position: refs/heads/master@{#32706}

Patch Set 1 : #

Patch Set 2 : Fixed compile time error due to missing header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -8528 lines) Patch
M test/cctest/cctest.h View 1 chunk +0 lines, -118 lines 0 comments Download
M test/cctest/cctest.gyp View 3 chunks +7 lines, -6 lines 0 comments Download
D test/cctest/heap-tester.h View 1 chunk +0 lines, -82 lines 0 comments Download
A + test/cctest/heap/heap-tester.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/cctest/heap/test-alloc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/cctest/heap/test-heap.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/cctest/heap/test-incremental-marking.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/cctest/heap/test-mark-compact.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/cctest/heap/test-spaces.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/cctest/heap/utils-inl.h View 1 chunk +138 lines, -0 lines 0 comments Download
D test/cctest/test-alloc.cc View 1 chunk +0 lines, -256 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-dictionary.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
D test/cctest/test-heap.cc View 1 chunk +0 lines, -6450 lines 0 comments Download
D test/cctest/test-incremental-marking.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D test/cctest/test-mark-compact.cc View 1 chunk +0 lines, -498 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-slots-buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
D test/cctest/test-spaces.cc View 1 chunk +0 lines, -931 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
Michael Lippautz
PTAL; I am trying to bundle heap-related tests and utilities to get a better overview. ...
5 years ago (2015-12-08 13:51:07 UTC) #5
ulan
lgtm
5 years ago (2015-12-08 13:55:20 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512553002/20001
5 years ago (2015-12-08 13:57:16 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/7501)
5 years ago (2015-12-08 14:03:02 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512553002/40001
5 years ago (2015-12-08 14:12:42 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11152) v8_linux_nodcheck_rel on ...
5 years ago (2015-12-08 15:01:39 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512553002/40001
5 years ago (2015-12-08 16:09:29 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/11463)
5 years ago (2015-12-08 19:06:25 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512553002/40001
5 years ago (2015-12-09 09:50:08 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 10:59:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512553002/40001
5 years ago (2015-12-09 11:22:33 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-12-09 11:25:32 UTC) #27
commit-bot: I haz the power
5 years ago (2015-12-09 11:26:24 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ad016d361cae0f8aa2eb8ad4bfda69038d2a944
Cr-Commit-Position: refs/heads/master@{#32706}

Powered by Google App Engine
This is Rietveld 408576698