Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 151253002: Fix python path for gyp. (Closed)

Created:
6 years, 10 months ago by Michael Achenbach
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Makefile View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Michael Achenbach
PTAL. I wonder why we didn't need that before... but after running make dependencies now ...
6 years, 10 months ago (2014-01-31 08:56:51 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-01-31 08:59:58 UTC) #2
Michael Achenbach
Hum - "sudo apt-get remove gyp" did the trick... then I'd rather not commit this.
6 years, 10 months ago (2014-01-31 09:02:17 UTC) #3
jochen (gone - plz use gerrit)
On 2014/01/31 09:02:17, Michael Achenbach wrote: > Hum - "sudo apt-get remove gyp" did the ...
6 years, 10 months ago (2014-01-31 09:07:22 UTC) #4
Jakob Kummerow
On 2014/01/31 09:02:17, Michael Achenbach wrote: > then I'd rather not commit this. I was ...
6 years, 10 months ago (2014-01-31 09:07:46 UTC) #5
Michael Achenbach
Ok - agreed. It is more consistent if "make dependencies" and "make xxx" match the ...
6 years, 10 months ago (2014-01-31 09:09:09 UTC) #6
Michael Achenbach
Committed patchset #1 manually as r18974 (presubmit successful).
6 years, 10 months ago (2014-01-31 09:09:49 UTC) #7
Nico
Are you sure this does anything? Nicos-MacBook-Pro:tmp thakis$ cat Makefile foo: PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(PYTHONPATH)" \ PYTHONPATH="$(shell ...
6 years, 6 months ago (2014-06-24 04:35:14 UTC) #8
Michael Achenbach
6 years, 6 months ago (2014-06-25 07:11:20 UTC) #9
Message was sent while issue was closed.
On 2014/06/24 04:35:14, Nico (away) wrote:
> Are you sure this does anything?
> 
> Nicos-MacBook-Pro:tmp thakis$ cat Makefile 
> foo:
> 	PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(PYTHONPATH)" \
> 	PYTHONPATH="$(shell pwd)/build/gyp/pylib:$(PYTHONPATH)" \
> 	bash -c 'echo $${PYTHONPATH}'
> 
> .PHONY: foo
> Nicos-MacBook-Pro:tmp thakis$ make
> PYTHONPATH="/Users/thakis/src/tmp/tools/generate_shim_headers:" \
> 	PYTHONPATH="/Users/thakis/src/tmp/build/gyp/pylib:" \
> 	bash -c 'echo ${PYTHONPATH}'
> /Users/thakis/src/tmp/build/gyp/pylib:
> 
> 
> Looks like the first path is just ignored…

Interesting. I wonder why we could live without generate_shim_headers in our
path?

Powered by Google App Engine
This is Rietveld 408576698