Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1512513002: VM: Don't inline array allocation in precompiled code (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Don't inline array allocation in precompiled code This reduces generated code size by around 3-4% on ARM and x64. Performance impact is mostly neutral because precompiled code is generally dominated by other factors, and especially ARM often benefits from smaller generated code. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/12b0aa1ba85849fded2374f8f4dd22a5af3b9276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
5 years ago (2015-12-08 08:51:47 UTC) #3
rmacnak
lgtm
5 years ago (2015-12-08 18:31:06 UTC) #4
Florian Schneider
5 years ago (2015-12-09 10:40:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12b0aa1ba85849fded2374f8f4dd22a5af3b9276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698