Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1512503002: Update List.sort documentation to state that it isn't stable. (Closed)

Created:
5 years ago by Lasse Reichstein Nielsen
Modified:
5 years ago
Reviewers:
eernst
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update List.sort documentation to state that it isn't stable. Fixes issue #23976. BUG= http://dartbug.com/23976 R=eernst@google.com Committed: https://github.com/dart-lang/sdk/commit/674a2f6d90ea063b13a33a74d7bb010f062ae8fe

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M sdk/lib/core/list.dart View 1 chunk +13 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
5 years ago (2015-12-08 08:42:32 UTC) #2
eernst
lgtm https://codereview.chromium.org/1512503002/diff/1/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://codereview.chromium.org/1512503002/diff/1/sdk/lib/core/list.dart#newcode214 sdk/lib/core/list.dart:214: * print(numbers); // [one, two, four, three] OR ...
5 years ago (2015-12-08 09:02:08 UTC) #3
Lasse Reichstein Nielsen
5 years ago (2015-12-08 09:24:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
674a2f6d90ea063b13a33a74d7bb010f062ae8fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698