Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1512473002: Oilpan: fix build after r363737. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r363737. Leave CompositorProxiedPropertySet off the Oilpan heap for now. R=haraken BUG=430155 NOTRY=true Committed: https://crrev.com/fc066de2af9565af4d8d2e7f0f39ecd9d8b9c15e Cr-Commit-Position: refs/heads/master@{#363762}

Patch Set 1 #

Patch Set 2 : ICWUify CompositorProxiedPropertySet.h #

Patch Set 3 : another include addition needed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/CompositorProxiedPropertySet.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxiedPropertySet.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
The ElementRareData extra member wasn't being traced; but it doesn't have to be in the ...
5 years ago (2015-12-08 07:36:27 UTC) #1
haraken
LGTM
5 years ago (2015-12-08 07:49:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512473002/40001
5 years ago (2015-12-08 08:05:10 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-08 09:01:09 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-08 09:02:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc066de2af9565af4d8d2e7f0f39ecd9d8b9c15e
Cr-Commit-Position: refs/heads/master@{#363762}

Powered by Google App Engine
This is Rietveld 408576698