Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/app/main_dll_loader_win.cc

Issue 1512463003: win: Get Kasko crash keys from Crashpad instead of Breakpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/main_dll_loader_win.cc
diff --git a/chrome/app/main_dll_loader_win.cc b/chrome/app/main_dll_loader_win.cc
index 4f5a519a5c05f9f067c6b92f88e69867632c7959..95ae8b6066a70b81a9e5e5acdf22221ed5f83553 100644
--- a/chrome/app/main_dll_loader_win.cc
+++ b/chrome/app/main_dll_loader_win.cc
@@ -44,7 +44,6 @@
#include "chrome/installer/util/install_util.h"
#include "chrome/installer/util/module_util_win.h"
#include "chrome/installer/util/util_constants.h"
-#include "components/crash/content/app/crash_keys_win.h"
#include "components/crash/content/app/crash_reporter_client.h"
#include "components/crash/content/app/crashpad.h"
#include "components/startup_metric_utils/browser/pre_read_field_trial_utils_win.h"
@@ -351,15 +350,6 @@ void ChromeDllLoader::OnBeforeLaunch(const std::string& process_type,
is_per_user_install)) {
minidump_type = kasko::api::LARGER_DUMP_TYPE;
}
-
- // TODO(scottmg): http://crbug.com/564329 Breakpad is no longer
- // initialized. For now, initialize the CustomInfoEntries here so
- // Kasko can pull them out.
- static breakpad::CrashKeysWin crash_keys_win;
- crash_keys_win.GetCustomInfo(
- exe_path.value(), base::UTF8ToUTF16(process_type),
- GetProfileType(), base::CommandLine::ForCurrentProcess(),
- &chrome_crash_client);
}
kasko_client_.reset(

Powered by Google App Engine
This is Rietveld 408576698