win: Get Kasko crash keys from Crashpad instead of Breakpad

components/crash/content/app/crashpad.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/app/crashpad.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 223 matching lines @@
       uploaded_reports->push_back(uploaded_report);
     }
   }
 
   std::sort(uploaded_reports->begin(), uploaded_reports->end(),
             [](const UploadedReport& a, const UploadedReport& b) {
               return a.creation_time >= b.creation_time;
             });
 }
 
+#if defined(KASKO)
+
+void GetCrashKeysForKasko(std::vector<kasko::api::CrashKey>* crash_keys) {
+  crash_keys->clear();
+  crash_keys->reserve(g_simple_string_dictionary->GetCount());
+  crashpad::SimpleStringDictionary::Iterator iter(*g_simple_string_dictionary);
+  for (;;) {

[Mark Mentovai, 2015/12/15 18:19:34]

I like

  while ((entry = iter.Next()) != nullptr)

but I feel like we may have been down this road before and you had reasons for
writing it this way, which is fine too.

[scottmg, 2015/12/15 18:37:12]

My main reason is that I feel like there'll be a compiler or config or linter or
sanitizer somewhere, eventually, that will complain about assignment in the
conditional, so I just don't bother.

But I don't feel too strongly about either being easier to read.

[grt (UTC plus 2), 2015/12/15 20:12:36]

?
  for (const auto* entry = iter.Next(); entry; entry = iter.Next()) {

[scottmg, 2015/12/15 20:20:01]

But then there's unnecessary duplication of "iter.Next()". /shrug

+    const auto* entry = iter.Next();
+    if (!entry)
+      break;
+    kasko::api::CrashKey kv;
+    wcsncpy_s(kv.name, base::UTF8ToWide(entry->key).c_str(), _TRUNCATE);
+    wcsncpy_s(kv.value, base::UTF8ToWide(entry->value).c_str(), _TRUNCATE);
+    crash_keys->push_back(kv);
+  }
+}
+
+#endif  // KASKO
+
 }  // namespace crash_reporter
 
 #if defined(OS_WIN)
 
 extern "C" {
 
 // NOTE: This function is used by SyzyASAN to annotate crash reports. If you
 // change the name or signature of this function you will break SyzyASAN
 // instrumented releases of Chrome. Please contact syzygy-team@chromium.org
 // before doing so! See also http://crbug.com/567781.
 void __declspec(dllexport) __cdecl SetCrashKeyValueImpl(const wchar_t* key,
                                                         const wchar_t* value) {
   crash_reporter::SetCrashKeyValue(base::UTF16ToUTF8(key),
                                    base::UTF16ToUTF8(value));
 }
 
 void __declspec(dllexport) __cdecl ClearCrashKeyValueImpl(const wchar_t* key) {
   crash_reporter::ClearCrashKey(base::UTF16ToUTF8(key));
 }
 
 }  // extern "C"
 
 #endif  // OS_WIN