Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1512423003: Convert last batch of casts in fwl. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -52 lines) Patch
M xfa/include/fwl/core/fwl_note.h View 1 chunk +2 lines, -0 lines 1 comment Download
M xfa/include/fwl/lightwidget/barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_noteimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/core/include/fwl_noteimp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/picturebox.cpp View 3 chunks +4 lines, -4 lines 1 comment Download
M xfa/src/fwl/src/lightwidget/scrollbar.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/theme.cpp View 7 chunks +9 lines, -14 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/widget.cpp View 4 chunks +8 lines, -8 lines 1 comment Download
M xfa/src/fwl/src/theme/widgettp.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/1512423003/diff/1/xfa/include/fwl/core/fwl_note.h File xfa/include/fwl/core/fwl_note.h (right): https://codereview.chromium.org/1512423003/diff/1/xfa/include/fwl/core/fwl_note.h#newcode343 xfa/include/fwl/core/fwl_note.h:343: virtual IFWL_Widget* GetFocus() = 0; Note: ...
5 years ago (2015-12-10 22:40:35 UTC) #2
Lei Zhang
lgtm
5 years ago (2015-12-10 23:27:22 UTC) #3
Tom Sepez
5 years ago (2015-12-10 23:53:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d75b8537a1286af979b0d0fb19988a29af7c4a33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698