services/python/content_handler/BUILD.gn - Issue 1512343002: Remove the //mojo/public/c/system:for_shared_library target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/python/content_handler/BUILD.gn

Issue 1512343002: Remove the //mojo/public/c/system:for_shared_library target. (Closed) Base URL: https://github.com/domokit/mojo.git@c_system_target_1

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/python/content_handler/BUILD.gn

diff --git a/services/python/content_handler/BUILD.gn b/services/python/content_handler/BUILD.gn

index c17e0fb56dbd186e180d585a16f65d0a1629d597..a326aa6799bcc6b6d1361975e2249613570b58f9 100644

--- a/services/python/content_handler/BUILD.gn

+++ b/services/python/content_handler/BUILD.gn

@@ -25,7 +25,7 @@ python_binary_source_set("content_handler_src") {

"//mojo/application:content_handler",

"//mojo/data_pipe_utils",

"//mojo/environment:chromium",

- "//mojo/public/c/system:for_shared_library",

+ "//mojo/public/c/system",

viettrungluu 2015/12/10 16:50:06 The .../native:system dependency belongs in the "b

"//mojo/public/cpp/utility",

"//mojo/public/python:python_common",

"//mojo/public/python:system_embedded",

@@ -64,7 +64,7 @@ python_binary_source_set("mojo_system_impl") {

"//base",

"//mojo/environment:chromium",

"//mojo/message_pump",

- "//mojo/public/c/system:for_shared_library",

+ "//mojo/public/c/system",

viettrungluu 2015/12/10 16:50:06 "

"//mojo/public/cpp/system",

"//mojo/public/cpp/utility",

"//mojo/public/cpp/bindings:callback",

« services/java_handler/BUILD.gn ('K') | « services/java_handler/BUILD.gn ('k') | ui/ozone/demo/BUILD.gn » ('j') | ui/ozone/demo/BUILD.gn » ('J')