Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: mojo/public/mojo_application.gni

Issue 1512343002: Remove the //mojo/public/c/system:for_shared_library target. (Closed) Base URL: https://github.com/domokit/mojo.git@c_system_target_1
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/mojo_application.gni
diff --git a/mojo/public/mojo_application.gni b/mojo/public/mojo_application.gni
index be9dadaba9f3db06e378ac18c2a62d5a2041aaa0..b7be2138af27c1f80d01454903df8b0baa2a9721 100644
--- a/mojo/public/mojo_application.gni
+++ b/mojo/public/mojo_application.gni
@@ -67,12 +67,8 @@ template("mojo_native_application") {
mojo_root) ]
}
- deps = rebase_path([
- "mojo/public/c/system",
viettrungluu 2015/12/10 16:50:06 Building the "binary" doesn't need the headers, on
- "mojo/public/platform/native:system",
- ],
- ".",
- mojo_root)
+ deps =
+ rebase_path([ "mojo/public/platform/native:system" ], ".", mojo_root)
if (defined(invoker.deps)) {
deps += invoker.deps
}
@@ -310,7 +306,8 @@ if (is_android) {
sources = invoker.sources
}
- deps = []
+ deps =
viettrungluu 2015/12/10 16:50:06 This is building a "binary", so should have this d
+ rebase_path([ "mojo/public/platform/native:system" ], ".", mojo_root)
if (defined(invoker.jni_package)) {
deps += [ ":${generate_jni_name}" ]
}

Powered by Google App Engine
This is Rietveld 408576698