Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1512303002: dart2js cps: Add instruction for bounds checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update gvn_test output Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart ('k') | pkg/compiler/lib/src/cps_ir/finalize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index cecec47b6d2d5a9fb1ae881e123705cd1b24c312..e732f3dccee6d415dcb5d4962896cab94a21ee16 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -391,6 +391,17 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
return 'Refinement $value ${node.refineType}';
}
+ visitBoundsCheck(cps_ir.BoundsCheck node) {
+ String object = formatReference(node.object);
+ String index = node.index == null
+ ? 'no-index'
+ : formatReference(node.index);
+ String length = node.length == null
+ ? 'no-length'
+ : formatReference(node.length);
+ return 'BoundsCheck $object $index $length ${node.checkString}';
+ }
+
visitNullCheck(cps_ir.NullCheck node) {
String value = formatReference(node.value);
String condition = formatReference(node.condition);
@@ -679,6 +690,10 @@ class BlockCollector implements cps_ir.Visitor {
unexpectedNode(node);
}
+ visitBoundsCheck(cps_ir.BoundsCheck node) {
+ unexpectedNode(node);
+ }
+
visitNullCheck(cps_ir.NullCheck node) {
unexpectedNode(node);
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart ('k') | pkg/compiler/lib/src/cps_ir/finalize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698