Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1512293003: Silence another PNG print statement (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
msarett, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Silence another PNG print statement It can still be turned on by using setting c_suppressPNGImageDecoderWarnings to true. Committed: https://skia.googlesource.com/skia/+/04a0d3f00ec758b376b404b8370aeabdc4529ca0

Patch Set 1 #

Patch Set 2 : Reverse bool to the desired value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/images/SkImageDecoder_libpng.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
scroggo
5 years ago (2015-12-10 16:32:10 UTC) #2
caryclark
lgtm
5 years ago (2015-12-10 16:33:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512293003/20001
5 years ago (2015-12-10 16:37:31 UTC) #6
msarett
lgtm
5 years ago (2015-12-10 16:51:06 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-10 16:54:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/04a0d3f00ec758b376b404b8370aeabdc4529ca0

Powered by Google App Engine
This is Rietveld 408576698