Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1512273002: Handle the case when a mediastream track doesn't have extra data. (Closed)

Created:
5 years ago by tommi (sloooow) - chröme
Modified:
5 years ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle the case when a mediastream track doesn't have extra data. This can happen if a track was cloned. R=perkj BUG=121673 Committed: https://crrev.com/75287dc569fa28f23788f6324cd120d370932777 Cr-Commit-Position: refs/heads/master@{#364347}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/renderer/media/media_stream_renderer_factory_impl.cc View 1 chunk +9 lines, -1 line 2 comments Download

Messages

Total messages: 14 (6 generated)
tommi (sloooow) - chröme
5 years ago (2015-12-10 12:29:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512273002/1
5 years ago (2015-12-10 12:29:37 UTC) #4
perkj_chrome
lgtm, but maybe specify more when this is a problem. https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/media_stream_renderer_factory_impl.cc File content/renderer/media/media_stream_renderer_factory_impl.cc (right): https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/media_stream_renderer_factory_impl.cc#newcode147 ...
5 years ago (2015-12-10 12:44:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 13:33:48 UTC) #7
tommi (sloooow) - chröme
https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/media_stream_renderer_factory_impl.cc File content/renderer/media/media_stream_renderer_factory_impl.cc (right): https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/media_stream_renderer_factory_impl.cc#newcode147 content/renderer/media/media_stream_renderer_factory_impl.cc:147: // TODO(tommi, perkj): Fix cloning of tracks to handle ...
5 years ago (2015-12-10 13:37:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512273002/1
5 years ago (2015-12-10 13:58:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 14:04:18 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 14:05:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75287dc569fa28f23788f6324cd120d370932777
Cr-Commit-Position: refs/heads/master@{#364347}

Powered by Google App Engine
This is Rietveld 408576698