|
|
Created:
5 years ago by tommi (sloooow) - chröme Modified:
5 years ago Reviewers:
perkj_chrome CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionHandle the case when a mediastream track doesn't have extra data.
This can happen if a track was cloned.
R=perkj
BUG=121673
Committed: https://crrev.com/75287dc569fa28f23788f6324cd120d370932777
Cr-Commit-Position: refs/heads/master@{#364347}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 14 (6 generated)
Description was changed from ========== Handle the case when a mediastream track doesn't have extra data. This can happen if a track was cloned. R=perkj BUG= ========== to ========== Handle the case when a mediastream track doesn't have extra data. This can happen if a track was cloned. R=perkj BUG=121673 ==========
The CQ bit was checked by tommi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512273002/1
lgtm, but maybe specify more when this is a problem. https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/medi... File content/renderer/media/media_stream_renderer_factory_impl.cc (right): https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_renderer_factory_impl.cc:147: // TODO(tommi, perkj): Fix cloning of tracks to handle extra data too. Is this an audio track problem in general or only webaudio? Cloning is triggered from here: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... And implemented in chrome here. https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/medi... File content/renderer/media/media_stream_renderer_factory_impl.cc (right): https://codereview.chromium.org/1512273002/diff/1/content/renderer/media/medi... content/renderer/media/media_stream_renderer_factory_impl.cc:147: // TODO(tommi, perkj): Fix cloning of tracks to handle extra data too. On 2015/12/10 12:44:44, perkj wrote: > Is this an audio track problem in general or only webaudio? In general and I don't think this is an issue with webaudio tracks actually. > Cloning is triggered from here: > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... > > And implemented in chrome here. > https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m... Yes I know and the problem with that implementation is that the extra data is not cloned and there's no way to get to the original source of the original track. For remote tracks for example, there will never be a "native" source or track.
The CQ bit was checked by tommi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512273002/1
Message was sent while issue was closed.
Description was changed from ========== Handle the case when a mediastream track doesn't have extra data. This can happen if a track was cloned. R=perkj BUG=121673 ========== to ========== Handle the case when a mediastream track doesn't have extra data. This can happen if a track was cloned. R=perkj BUG=121673 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Handle the case when a mediastream track doesn't have extra data. This can happen if a track was cloned. R=perkj BUG=121673 ========== to ========== Handle the case when a mediastream track doesn't have extra data. This can happen if a track was cloned. R=perkj BUG=121673 Committed: https://crrev.com/75287dc569fa28f23788f6324cd120d370932777 Cr-Commit-Position: refs/heads/master@{#364347} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/75287dc569fa28f23788f6324cd120d370932777 Cr-Commit-Position: refs/heads/master@{#364347} |