Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1512253003:
[harmony] stage regexp lookbehind assertions. (Closed)
Description[harmony] stage regexp lookbehind assertions.
R=littledan@chromium.org, rossberg@chromium.org
BUG=v8:4545
LOG=Y
Committed: https://crrev.com/02633ddec1d410da5a5d8f7ea0fcfa572ad8820c
Cr-Commit-Position: refs/heads/master@{#32830}
Patch Set 1 #Patch Set 2 : move test back to test/mjsunit/harmony #
Messages
Total messages: 22 (8 generated)
On 2015/12/11 10:01:57, Yang wrote: Not sure whether we want to do this now. The implementation is complete, and just sitting around. Maybe we want to stage it so that at least it can be tested by people who have the chrome flag enabled?
On 2015/12/11 10:18:53, Yang wrote: > On 2015/12/11 10:01:57, Yang wrote: > > Not sure whether we want to do this now. The implementation is complete, and > just sitting around. Maybe we want to stage it so that at least it can be tested > by people who have the chrome flag enabled? I think in this case it's fine to stage this now. But FWIW, don't move tests to esN dir before the corresponding flag is removed.
On 2015/12/11 10:21:57, rossberg wrote: > On 2015/12/11 10:18:53, Yang wrote: > > On 2015/12/11 10:01:57, Yang wrote: > > > > Not sure whether we want to do this now. The implementation is complete, and > > just sitting around. Maybe we want to stage it so that at least it can be > tested > > by people who have the chrome flag enabled? > > I think in this case it's fine to stage this now. > > But FWIW, don't move tests to esN dir before the corresponding flag is removed. (Also, it's perhaps more likely to become ES8.)
On 2015/12/11 10:23:03, rossberg wrote: > On 2015/12/11 10:21:57, rossberg wrote: > > On 2015/12/11 10:18:53, Yang wrote: > > > On 2015/12/11 10:01:57, Yang wrote: > > > > > > Not sure whether we want to do this now. The implementation is complete, and > > > just sitting around. Maybe we want to stage it so that at least it can be > > tested > > > by people who have the chrome flag enabled? > > > > I think in this case it's fine to stage this now. > > > > But FWIW, don't move tests to esN dir before the corresponding flag is > removed. > > (Also, it's perhaps more likely to become ES8.) Thanks for the comment. I moved the test back to test/mjsunit/harmony.
The CQ bit was checked by yangguo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512253003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Staging sounds good to me. This is an experimental web feature, and will remain experimental for a while. But I'd wait for Andreas's LGTM.
Description was changed from ========== [es7] stage regexp lookbehind assertions. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y ========== to ========== [harmony] stage regexp lookbehind assertions. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y ==========
lgtm
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512253003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/514) v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512253003/20001
Message was sent while issue was closed.
Description was changed from ========== [harmony] stage regexp lookbehind assertions. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y ========== to ========== [harmony] stage regexp lookbehind assertions. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [harmony] stage regexp lookbehind assertions. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y ========== to ========== [harmony] stage regexp lookbehind assertions. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y Committed: https://crrev.com/02633ddec1d410da5a5d8f7ea0fcfa572ad8820c Cr-Commit-Position: refs/heads/master@{#32830} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/02633ddec1d410da5a5d8f7ea0fcfa572ad8820c Cr-Commit-Position: refs/heads/master@{#32830} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
