Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1512253003: [harmony] stage regexp lookbehind assertions. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[harmony] stage regexp lookbehind assertions. R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y Committed: https://crrev.com/02633ddec1d410da5a5d8f7ea0fcfa572ad8820c Cr-Commit-Position: refs/heads/master@{#32830}

Patch Set 1 #

Patch Set 2 : move test back to test/mjsunit/harmony #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
Yang
5 years ago (2015-12-11 10:01:57 UTC) #1
Yang
On 2015/12/11 10:01:57, Yang wrote: Not sure whether we want to do this now. The ...
5 years ago (2015-12-11 10:18:53 UTC) #2
rossberg
On 2015/12/11 10:18:53, Yang wrote: > On 2015/12/11 10:01:57, Yang wrote: > > Not sure ...
5 years ago (2015-12-11 10:21:57 UTC) #3
rossberg
On 2015/12/11 10:21:57, rossberg wrote: > On 2015/12/11 10:18:53, Yang wrote: > > On 2015/12/11 ...
5 years ago (2015-12-11 10:23:03 UTC) #4
Yang
On 2015/12/11 10:23:03, rossberg wrote: > On 2015/12/11 10:21:57, rossberg wrote: > > On 2015/12/11 ...
5 years ago (2015-12-11 12:05:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512253003/20001
5 years ago (2015-12-11 12:05:47 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 14:06:51 UTC) #9
Dan Ehrenberg
lgtm Staging sounds good to me. This is an experimental web feature, and will remain ...
5 years ago (2015-12-11 18:55:42 UTC) #10
rossberg
lgtm
5 years ago (2015-12-14 10:31:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512253003/20001
5 years ago (2015-12-14 10:32:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/514) v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-14 11:01:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512253003/20001
5 years ago (2015-12-14 11:12:39 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-14 11:29:06 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-14 11:29:52 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02633ddec1d410da5a5d8f7ea0fcfa572ad8820c
Cr-Commit-Position: refs/heads/master@{#32830}

Powered by Google App Engine
This is Rietveld 408576698