Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1512243002: [turbofan] Get rid of truncation by store. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Get rid of truncation by store. Nowadays, representation inference and simplified lowering can insert the right truncations based on the use. Committed: https://crrev.com/9c87bd4b8225b7695d453967a9acdd663e5c0443 Cr-Commit-Position: refs/heads/master@{#32747}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please?
5 years ago (2015-12-10 08:14:49 UTC) #3
Benedikt Meurer
Awesome, LGTM!
5 years ago (2015-12-10 08:15:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512243002/20001
5 years ago (2015-12-10 11:21:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 11:23:14 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-10 11:24:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c87bd4b8225b7695d453967a9acdd663e5c0443
Cr-Commit-Position: refs/heads/master@{#32747}

Powered by Google App Engine
This is Rietveld 408576698