Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1512233002: PPAPI/NaCl: Move plugin_main.cc's contents into irt_ppapi.cc (Closed)

Created:
5 years ago by Mark Seaborn
Modified:
5 years ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI/NaCl: Move plugin_main.cc's contents into irt_ppapi.cc My intent here is just to make the code easier to follow. plugin_main.cc and irt_ppapi.cc are both quite small, and there's no need for the code to be split between the two. * Inline PpapiPluginMain() into irt_ppapi_start(). * irt_shim_ppapi.c: Remove a duplicated function declaration. We can use the one from irt_ppapi.h instead. BUG=none TEST=build Committed: https://crrev.com/879549c06bb3729bb2a47ec1f6e9a02319e9ea4f Cr-Commit-Position: refs/heads/master@{#364514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -77 lines) Patch
M ppapi/nacl_irt/irt_ppapi.h View 1 chunk +14 lines, -1 line 0 comments Download
M ppapi/nacl_irt/irt_ppapi.cc View 1 chunk +32 lines, -2 lines 0 comments Download
D ppapi/nacl_irt/plugin_main.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ppapi/nacl_irt/plugin_main.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M ppapi/nacl_irt/plugin_startup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/irt_shim_ppapi.c View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512233002/1
5 years ago (2015-12-10 07:42:27 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 08:45:20 UTC) #4
Mark Seaborn
5 years ago (2015-12-10 22:05:23 UTC) #7
bbudge
lgtm
5 years ago (2015-12-10 22:42:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512233002/1
5 years ago (2015-12-10 22:46:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 23:07:52 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 23:08:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/879549c06bb3729bb2a47ec1f6e9a02319e9ea4f
Cr-Commit-Position: refs/heads/master@{#364514}

Powered by Google App Engine
This is Rietveld 408576698