Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/about_flags.cc

Issue 1512113002: Read feature param for Physical Web experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Used new feature API Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | chrome/browser/android/chrome_feature_list.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index fe09246d80a20b0f35bc4d85547cd79a662c4e2c..befa498c419ad607f16f94aea7add314c46ab3d1 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -23,6 +23,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "cc/base/switches.h"
+#include "chrome/browser/android/chrome_feature_list.h"
Alexei Svitkine (slow) 2015/12/21 15:50:50 I think this needs to be in ifdef android, since i
cco3 2015/12/21 18:10:11 Done.
#include "chrome/common/channel_info.h"
#include "chrome/common/chrome_content_client.h"
#include "chrome/common/chrome_switches.h"
@@ -1325,7 +1326,7 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME,
IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION,
kOsAndroid,
- SINGLE_VALUE_TYPE(switches::kEnablePhysicalWeb)},
+ FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)},
#endif
{"enable-zero-copy",
IDS_FLAGS_ZERO_COPY_NAME,
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | chrome/browser/android/chrome_feature_list.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698