Read feature param for Physical Web experiment

chrome/browser/android/chrome_feature_list.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/chrome_feature_list.h"
 
 #include <string>
 
 #include "base/android/jni_string.h"
-#include "base/feature_list.h"
 #include "jni/ChromeFeatureList_jni.h"
 
 using base::android::ConvertJavaStringToUTF8;
 
 namespace chrome {
 namespace android {
 
 namespace {
 
-const base::Feature kPhysicalWebFeature {
-  "PhysicalWeb", base::FEATURE_DISABLED_BY_DEFAULT
-};
-
 // Array of features exposed through the Java ChromeFeatureList API. Entries in
 // this array may either refer to features defined in this file (above) or in
 // other locations in the code base (e.g. chrome/, components/, etc).
 const base::Feature* kFeaturesExposedToJava[] = {
     &kPhysicalWebFeature,
 };
 
 }  // namespace
 
 static jboolean IsEnabled(JNIEnv* env,
                           const JavaParamRef<jclass>& clazz,
                           const JavaParamRef<jstring>& jfeature_name) {
   const std::string feature_name = ConvertJavaStringToUTF8(env, jfeature_name);
   for (size_t i = 0; i < arraysize(kFeaturesExposedToJava); ++i) {
     if (kFeaturesExposedToJava[i]->name == feature_name)
       return base::FeatureList::IsEnabled(*kFeaturesExposedToJava[i]);
   }
   // Features queried via this API must be present in |kFeaturesExposedToJava|.
   NOTREACHED();
   return false;
 }
 
 bool RegisterChromeFeatureListJni(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
+const base::Feature kPhysicalWebFeature {

[mmocny, 2015/12/21 15:45:55]

I don't expect its a good idea to use static initialization of a non-POD type
like this.

I'm not sure what the style guide for chromium says about it, but typically you
either wrap in a Get*() function which itself holds the static data, or create a
global plain *pointer* to the object.

[Alexei Svitkine (slow), 2015/12/21 15:50:50]

It's a POD type and this is the correct way to initialize it. (See the docs in
base/feature_list.h)

+  "PhysicalWeb", base::FEATURE_DISABLED_BY_DEFAULT
+};

[Alexei Svitkine (slow), 2015/12/21 15:48:18]

Nit: I'd put this after line 27.

[cco3, 2015/12/21 18:10:11]

Done.

+
 }  // namespace android
 }  // namespace chrome