Read feature param for Physical Web experiment

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 48 matching lines @@
 #include "ui/base/ui_base_switches.h"
 #include "ui/display/display_switches.h"
 #include "ui/events/event_switches.h"
 #include "ui/gfx/switches.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/keyboard/keyboard_switches.h"
 #include "ui/native_theme/native_theme_switches.h"
 #include "ui/views/views_switches.h"
 
 #if !defined(OS_ANDROID)
+#include "chrome/browser/android/chrome_feature_list.h"

[Alexei Svitkine (slow), 2015/12/21 19:02:17]

This is a !defined(OS_ANDROID) block. You want a new block that's
defined(OS_ANDROID) or have an else for this block (and probably reverse the
cond so defined is first).

[cco3, 2015/12/21 19:21:00]

Done.

 #include "ui/message_center/message_center_switches.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chromeos/chromeos_switches.h"
 #include "third_party/cros_system_api/switches/chrome_switches.h"
 #endif
 
 #if defined(OS_WIN)
 #include "components/search_engines/desktop_search_win.h"
@@ skipping 1239 matching lines @@
 #if defined(OS_ANDROID)
     {"enable-accessibility-tab-switcher",
      IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_NAME,
      IDS_FLAGS_ACCESSIBILITY_TAB_SWITCHER_DESCRIPTION,
      kOsAndroid,
      SINGLE_VALUE_TYPE(switches::kEnableAccessibilityTabSwitcher)},
     {"enable-physical-web",
      IDS_FLAGS_ENABLE_PHYSICAL_WEB_NAME,
      IDS_FLAGS_ENABLE_PHYSICAL_WEB_DESCRIPTION,
      kOsAndroid,
-     SINGLE_VALUE_TYPE(switches::kEnablePhysicalWeb)},
+     FEATURE_VALUE_TYPE(chrome::android::kPhysicalWebFeature)},
 #endif
     {"enable-zero-copy",
      IDS_FLAGS_ZERO_COPY_NAME,
      IDS_FLAGS_ZERO_COPY_DESCRIPTION,
      kOsAll,
      ENABLE_DISABLE_VALUE_TYPE(switches::kEnableZeroCopy,
                                switches::kDisableZeroCopy)},
 #if defined(OS_CHROMEOS)
     {"enable-first-run-ui-transitions",
      IDS_FLAGS_FIRST_RUN_UI_TRANSITIONS_NAME,
@@ skipping 953 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags