Create a WebFrameWidget for WebViewPlugin.

Create a WebFrameWidget for WebViewPlugin.

BUG=419087
Committed: https://crrev.com/ef517df9ab33928b03e81afbffb7b38a23b42767
Cr-Commit-Position: refs/heads/master@{#364468}

[lfg, 2015-12-10 00:21:05]

Description was changed from

==========
WIP
==========

to

==========
Create a WebFrameWidget for WebViewPlugin.

BUG=419087
==========

[lfg, 2015-12-10 00:21:38]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2015-12-10 00:21:39]

Hey Daniel, since you're getting a TODO with your name, I'm sending the review
to you first :)

[dcheng, 2015-12-10 00:44:10]

lgtm

isn't WebViewPlugin supposed to go away at some point? ;-)

[lfg, 2015-12-10 17:27:41]

lfg@chromium.org changed reviewers:
+ tommycli@chromium.org

[lfg, 2015-12-10 17:27:41]

tommycli@chromium.org: Please take a look.

[tommycli, 2015-12-10 18:21:03]

lfg: Looks good overall. For my own edification, what is a WebFrameWidget, and
what's the motivation for these changes?

dcheng: No plans to obsolete WebViewPlugin. There was an initiative by jbroman
to remove it in favor of a Shadow DOM plugin placeholder at some point, but that
effort stalled because there wasn't an established Shadow-DOM => C++ interface.

[dcheng, 2015-12-10 18:24:10]

On 2015/12/10 at 18:21:03, tommycli wrote:
> lfg: Looks good overall. For my own edification, what is a WebFrameWidget, and
what's the motivation for these changes?

WebWidget is currently a parent class of WebView, but we'd like to remove that
for OOPI: in a process where the main frame is remote, having the WebView be a
WebWidget doesn't make sense.

Instead, every local root gets a frame widget (WebFrameWidget) to coordinate
input/layout/painting.
https://docs.google.com/document/d/1CfoWjeq9KNNnb5HEG4_FvEu_9WWhIRzYwZDbXZRtd...
is a good reference.

> 
> dcheng: No plans to obsolete WebViewPlugin. There was an initiative by jbroman
to remove it in favor of a Shadow DOM plugin placeholder at some point, but that
effort stalled because there wasn't an established Shadow-DOM => C++ interface.

[lfg, 2015-12-10 18:29:17]

On 2015/12/10 18:21:03, tommycli wrote:
> lfg: Looks good overall. For my own edification, what is a WebFrameWidget, and
> what's the motivation for these changes?

dcheng@ has a written a very good document describing it here:
https://goo.gl/7yVrnb

Basically, we are working towards splitting the widget aspects of WebView to
better
support out-of-process iframes. It's similar to the work being done on the
content
side to split RenderView/RenderWidget if you are familiar with that.

[tommycli, 2015-12-10 18:32:39]

lgtm assuming my understanding is correct:

WebView currently handles painting, since it's a WebWidget.

Soon, WebView will no longer be a WebWidget, and you are adding a WebFrameWidget
to handle painting in the new OOPIF world.

[lfg, 2015-12-10 19:35:01]

On 2015/12/10 18:32:39, tommycli wrote:
> lgtm assuming my understanding is correct:
> 
> WebView currently handles painting, since it's a WebWidget.
> 
> Soon, WebView will no longer be a WebWidget, and you are adding a
WebFrameWidget
> to handle painting in the new OOPIF world.

That's right.

[lfg, 2015-12-10 19:35:11]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2015-12-10 19:39:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1512103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1512103002/1

[commit-bot: I haz the power, 2015-12-10 20:49:19]

Description was changed from

==========
Create a WebFrameWidget for WebViewPlugin.

BUG=419087
==========

to

==========
Create a WebFrameWidget for WebViewPlugin.

BUG=419087
==========

[commit-bot: I haz the power, 2015-12-10 20:49:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-10 20:51:06]

Description was changed from

==========
Create a WebFrameWidget for WebViewPlugin.

BUG=419087
==========

to

==========
Create a WebFrameWidget for WebViewPlugin.

BUG=419087

Committed: https://crrev.com/ef517df9ab33928b03e81afbffb7b38a23b42767
Cr-Commit-Position: refs/heads/master@{#364468}
==========

[commit-bot: I haz the power, 2015-12-10 20:51:07]

Patchset 1 (id:??) landed as
https://crrev.com/ef517df9ab33928b03e81afbffb7b38a23b42767
Cr-Commit-Position: refs/heads/master@{#364468}