Issue 15121002: Merge 199387 "Add window buttons (close and maximize) to the Fil..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15121002: Merge 199387 "Add window buttons (close and maximize) to the Fil..." (Closed)

Created:
7 years, 7 months ago by mtomasz

Modified:
7 years, 7 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 199387 "Add window buttons (close and maximize) to the Fil..." > Add window buttons (close and maximize) to the Files.app's new UI. > > In the new UI decoration buttons have been removed, and were replaced by html ones. However, in gallery they were still missing. This patch fixes this issue by adding these two buttons. > > TEST=Run Files.app, open a picture, try to maximize and close. Check if the back button also works. Check the legacy ui. Check the legacy Files.app. > BUG=236311 > > Review URL: https://chromiumcodereview.appspot.com/14759019 TBR=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199675

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+150 lines, -56 lines)			Patch
M	chrome/browser/resources/file_manager/css/common.css	View	4 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/css/file_manager.css	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/css/gallery.css	View	14 chunks	+51 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	2 chunks	+14 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_tasks.js	View	3 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/photo/gallery.js	View	9 chunks	+63 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199675.

Expand Messages | Collapse Messages