Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: scripts/slave/recipe_modules/isolate/api.py

Issue 1512093002: Revert "Switch remaining bots to new Telemetry GPU isolate." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 6
7 7
8 class IsolateApi(recipe_api.RecipeApi): 8 class IsolateApi(recipe_api.RecipeApi):
9 """APIs for interacting with isolates.""" 9 """APIs for interacting with isolates."""
10 10
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 self.m.chromium.runtest( 236 self.m.chromium.runtest(
237 self._run_isolated_path, 237 self._run_isolated_path,
238 args=self.runtest_args_list(test, args), 238 args=self.runtest_args_list(test, args),
239 # We must use the name of the test as the name in order to avoid 239 # We must use the name of the test as the name in order to avoid
240 # duplicate steps called "run_isolated". 240 # duplicate steps called "run_isolated".
241 name=name or test, 241 name=name or test,
242 revision=revision, 242 revision=revision,
243 webkit_revision=webkit_revision, 243 webkit_revision=webkit_revision,
244 **runtest_kwargs) 244 **runtest_kwargs)
245 245
246 def run_telemetry_test(self, isolate_name, test, revision, webkit_revision,
247 **runtest_kwargs):
248 """Runs a Telemetry test which has previously isolated to the server.
249
250 Uses runtest_args_list, above, and delegates to
251 api.chromium.run_telemetry_test.
252 """
253 self.m.chromium.run_telemetry_test(
254 self._run_isolated_path,
255 test,
256 # When running the Telemetry test via an isolate we need to tell
257 # run_isolated.py the hash and isolate server first, and then give
258 # the isolate the test name and other arguments separately.
259 prefix_args=self.runtest_args_list(isolate_name),
260 revision=revision,
261 webkit_revision=webkit_revision,
262 **runtest_kwargs)
263
246 def remove_build_metadata(self): 264 def remove_build_metadata(self):
247 """Removes the build metadata embedded in the build artifacts.""" 265 """Removes the build metadata embedded in the build artifacts."""
248 args = [ 266 args = [
249 '--build-dir', self.m.chromium.output_dir, 267 '--build-dir', self.m.chromium.output_dir,
250 '--src-dir', self.m.path['checkout'] 268 '--src-dir', self.m.path['checkout']
251 ] 269 ]
252 # Turn the failures during this step into warnings, it's a best effort step 270 # Turn the failures during this step into warnings, it's a best effort step
253 # that shouldn't break the build for now. 271 # that shouldn't break the build for now.
254 try: 272 try:
255 self.m.python('remove_build_metadata', 273 self.m.python('remove_build_metadata',
256 self.resource('remove_build_metadata.py'), 274 self.resource('remove_build_metadata.py'),
257 args=args, 275 args=args,
258 cwd=self.m.path['slave_build']) 276 cwd=self.m.path['slave_build'])
259 except self.m.step.StepFailure: 277 except self.m.step.StepFailure:
260 step_result = self.m.step.active_result 278 step_result = self.m.step.active_result
261 step_result.presentation.status = self.m.step.WARNING 279 step_result.presentation.status = self.m.step.WARNING
262 280
263 def compare_build_artifacts(self, first_dir, second_dir): 281 def compare_build_artifacts(self, first_dir, second_dir):
264 """Compare the artifacts from 2 builds.""" 282 """Compare the artifacts from 2 builds."""
265 args = [ 283 args = [
266 '--first-build-dir', first_dir, 284 '--first-build-dir', first_dir,
267 '--second-build-dir', second_dir, 285 '--second-build-dir', second_dir,
268 '--target-platform', self.m.chromium.c.TARGET_PLATFORM 286 '--target-platform', self.m.chromium.c.TARGET_PLATFORM
269 ] 287 ]
270 self.m.python('compare_build_artifacts', 288 self.m.python('compare_build_artifacts',
271 self.resource('compare_build_artifacts.py'), 289 self.resource('compare_build_artifacts.py'),
272 args=args, 290 args=args,
273 cwd=self.m.path['slave_build']) 291 cwd=self.m.path['slave_build'])
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/gpu/test_api.py ('k') | scripts/slave/recipe_modules/swarming/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698