Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: scripts/slave/recipe_modules/gpu/api.py

Issue 1512093002: Revert "Switch remaining bots to new Telemetry GPU isolate." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 from recipe_engine import recipe_api 6 from recipe_engine import recipe_api
7 7
8 import common 8 import common
9 9
10 SIMPLE_TESTS_TO_RUN = freeze([ 10 SIMPLE_TESTS_TO_RUN = freeze([
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 # Since performance tests aren't run on the debug builders, it isn't 196 # Since performance tests aren't run on the debug builders, it isn't
197 # necessary to build all of the targets there. 197 # necessary to build all of the targets there.
198 build_tag = '' if self.m.chromium.is_release_build else 'debug_' 198 build_tag = '' if self.m.chromium.is_release_build else 'debug_'
199 # It's harmless to process the isolate-related targets even if they 199 # It's harmless to process the isolate-related targets even if they
200 # aren't supported on the current configuration (because the component 200 # aren't supported on the current configuration (because the component
201 # build is used). 201 # build is used).
202 is_tryserver = self.m.tryserver.is_tryserver 202 is_tryserver = self.m.tryserver.is_tryserver
203 isolates = common.GPU_ISOLATES 203 isolates = common.GPU_ISOLATES
204 if self.is_fyi_waterfall: 204 if self.is_fyi_waterfall:
205 isolates += common.FYI_GPU_ISOLATES 205 isolates += common.FYI_GPU_ISOLATES
206 isolates += common.TELEMETRY_GPU_NEW_ISOLATE
206 if self.m.platform.is_win or self.m.platform.is_linux: 207 if self.m.platform.is_win or self.m.platform.is_linux:
207 # TODO(kbr): run these tests on the trybots as soon as there is 208 # TODO(kbr): run these tests on the trybots as soon as there is
208 # capacity to do so, and on all platforms as soon as ANGLE does. 209 # capacity to do so, and on all platforms as soon as ANGLE does.
209 isolates += common.WIN_AND_LINUX_ONLY_FYI_ONLY_GPU_ISOLATES 210 isolates += common.WIN_AND_LINUX_ONLY_FYI_ONLY_GPU_ISOLATES
210 if self.m.platform.is_win: 211 if self.m.platform.is_win:
211 isolates += common.WIN_ONLY_FYI_ONLY_GPU_ISOLATES 212 isolates += common.WIN_ONLY_FYI_ONLY_GPU_ISOLATES
212 targets = [u'%s_run' % test for test in isolates] 213 targets = [u'%s_run' % test for test in isolates]
213 self.m.isolate.clean_isolated_files( 214 self.m.isolate.clean_isolated_files(
214 self.m.chromium.c.build_dir.join(self.m.chromium.c.build_config_fs)) 215 self.m.chromium.c.build_dir.join(self.m.chromium.c.build_config_fs))
215 if is_tryserver: 216 if is_tryserver:
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
592 if self.m.platform.is_mac and not self.m.tryserver.is_tryserver: 593 if self.m.platform.is_mac and not self.m.tryserver.is_tryserver:
593 #TODO(zmo): remove the vmodule flag after crbug.com/424024 is fixed. 594 #TODO(zmo): remove the vmodule flag after crbug.com/424024 is fixed.
594 vmodules = [ 595 vmodules = [
595 'startup_browser_creator=2' 596 'startup_browser_creator=2'
596 ] 597 ]
597 extra_browser_args_string += ' --vmodule=' + ','.join(vmodules) 598 extra_browser_args_string += ' --vmodule=' + ','.join(vmodules)
598 if extra_browser_args: 599 if extra_browser_args:
599 extra_browser_args_string += ' ' + ' '.join(extra_browser_args) 600 extra_browser_args_string += ' ' + ' '.join(extra_browser_args)
600 test_args.append(extra_browser_args_string) 601 test_args.append(extra_browser_args_string)
601 602
602 # The step name must end in 'test' or 'tests' in order for the 603 # Run the new Telemetry GPU test isolate on the FYI waterfall.
603 # results to automatically show up on the flakiness dashboard. 604 # Once it's running well on all platforms, the old isolate, and
604 # (At least, this was true some time ago.) Continue to use this 605 # the code which launches it, will be removed.
605 # naming convention for the time being to minimize changes. 606 if self.is_fyi_waterfall:
606 step_name = name 607 # The step name must end in 'test' or 'tests' in order for the
607 if not (step_name.endswith('test') or step_name.endswith('tests')): 608 # results to automatically show up on the flakiness dashboard.
608 step_name = '%s_tests' % step_name 609 # (At least, this was true some time ago.) Continue to use this
609 # Prepend Telemetry GPU-specific flags. 610 # naming convention for the time being to minimize changes.
610 benchmark_name = target_name or name 611 step_name = name
611 prefix_args = [ 612 if not (step_name.endswith('test') or step_name.endswith('tests')):
612 benchmark_name, '--show-stdout', 613 step_name = '%s_tests' % step_name
613 '--browser=%s' % self.m.chromium.c.build_config_fs.lower() ] 614 # Prepend Telemetry GPU-specific flags.
614 if enable_swarming: 615 benchmark_name = target_name or name
615 return self.m.chromium_tests.steps.SwarmingIsolatedScriptTest( 616 prefix_args = [
616 name, args=prefix_args + test_args, 617 benchmark_name, '--show-stdout',
617 target_name='telemetry_gpu_new_test', 618 '--browser=%s' % self.m.chromium.c.build_config_fs.lower() ]
618 dimensions=swarming_dimensions,
619 tags={'gpu_test:1'},
620 extra_suffix=self._get_gpu_suffix(swarming_dimensions),
621 override_compile_targets=['telemetry_gpu_new_test_run'])
622 else:
623 return self.m.chromium_tests.steps.LocalIsolatedScriptTest( 619 return self.m.chromium_tests.steps.LocalIsolatedScriptTest(
624 step_name, args=prefix_args + test_args, 620 step_name, args=prefix_args + test_args,
625 target_name='telemetry_gpu_new_test', 621 target_name='telemetry_gpu_new_test',
626 override_compile_targets=['telemetry_gpu_new_test_run']) 622 override_compile_targets=['telemetry_gpu_new_test_run'])
623 else:
624 return self.m.chromium_tests.steps.TelemetryGPUTest(
625 name, chrome_revision, webkit_revision, args=test_args,
626 target_name=target_name, enable_swarming=enable_swarming,
627 swarming_dimensions=swarming_dimensions,
628 master_class_name=self._master_class_name_for_testing,
629 swarming_extra_suffix=self._get_gpu_suffix(swarming_dimensions))
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/steps.py ('k') | scripts/slave/recipe_modules/gpu/common.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698