src/images/SkImageDecoder_libpng.cpp - Issue 1512043002: Silence libpng warnings in SkImageDecoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkImageDecoder_libpng.cpp

Issue 1512043002: Silence libpng warnings in SkImageDecoder (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkImageDecoder_libpng.cpp

diff --git a/src/images/SkImageDecoder_libpng.cpp b/src/images/SkImageDecoder_libpng.cpp

index fd09ce95b0eaafb27065e4c3a5c204583c101c70..39ff9ce52a1c0d29bf3a78650c3d4dfd686f9f34 100644

--- a/src/images/SkImageDecoder_libpng.cpp

+++ b/src/images/SkImageDecoder_libpng.cpp

@@ -37,7 +37,7 @@

#define png_flush_ptr_NULL nullptr

#endif

-#if defined(SK_DEBUG)

+#if defined(SK_PRINT_CODEC_MESSAGES)

scroggo 2015/12/09 19:20:24 Does this file include SkCodecPriv? Given that we

msarett 2015/12/09 19:23:41 No. It only needs SkCodecPriv if we want to use S

#define DEFAULT_FOR_SUPPRESS_PNG_IMAGE_DECODER_WARNINGS false

#else // !defined(SK_DEBUG)

#define DEFAULT_FOR_SUPPRESS_PNG_IMAGE_DECODER_WARNINGS true

« no previous file with comments | « no previous file | no next file » | no next file with comments »