Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151203005: Add test code for readback comparision with more image pattens. (Closed)

Created:
6 years, 10 months ago by sivag
Modified:
6 years, 10 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add test code for readback comparision with more image pattens. BUG=323150 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251307

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add empty spaces between functions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -31 lines) Patch
M content/common/gpu/client/gl_helper_unittest.cc View 1 4 chunks +131 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sivag
PTAL..
6 years, 10 months ago (2014-02-04 16:06:16 UTC) #1
sivag
The CQ bit was checked by siva.gunturi@samsung.com
6 years, 10 months ago (2014-02-07 07:44:12 UTC) #2
sivag
The CQ bit was unchecked by siva.gunturi@samsung.com
6 years, 10 months ago (2014-02-07 07:44:13 UTC) #3
piman
lgtm https://codereview.chromium.org/151203005/diff/1/content/common/gpu/client/gl_helper_unittest.cc File content/common/gpu/client/gl_helper_unittest.cc (right): https://codereview.chromium.org/151203005/diff/1/content/common/gpu/client/gl_helper_unittest.cc#newcode956 content/common/gpu/client/gl_helper_unittest.cc:956: } nit: add empty line between functions https://codereview.chromium.org/151203005/diff/1/content/common/gpu/client/gl_helper_unittest.cc#newcode975 ...
6 years, 10 months ago (2014-02-13 20:34:02 UTC) #4
sivag
Done. https://codereview.chromium.org/151203005/diff/1/content/common/gpu/client/gl_helper_unittest.cc File content/common/gpu/client/gl_helper_unittest.cc (right): https://codereview.chromium.org/151203005/diff/1/content/common/gpu/client/gl_helper_unittest.cc#newcode956 content/common/gpu/client/gl_helper_unittest.cc:956: } On 2014/02/13 20:34:03, piman wrote: > nit: ...
6 years, 10 months ago (2014-02-14 05:48:47 UTC) #5
sivag
The CQ bit was checked by siva.gunturi@samsung.com
6 years, 10 months ago (2014-02-14 05:49:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/151203005/130001
6 years, 10 months ago (2014-02-14 05:49:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 08:45:26 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202093
6 years, 10 months ago (2014-02-14 08:45:27 UTC) #9
sivag
The CQ bit was checked by siva.gunturi@samsung.com
6 years, 10 months ago (2014-02-14 09:36:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/151203005/130001
6 years, 10 months ago (2014-02-14 09:39:03 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:15:38 UTC) #12
Message was sent while issue was closed. 
Change committed as 251307

Powered by Google App Engine
This is Rietveld 408576698