src/compiler/mips64/code-generator-mips64.cc - Issue 1512023002: [turbofan] Change TruncateFloat32ToUint64 to TryTruncateFloat32ToUint64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 1512023002: [turbofan] Change TruncateFloat32ToUint64 to TryTruncateFloat32ToUint64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/mips64/code-generator-mips64.cc

diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc

index 56c6fe19615c38b5df3c1db4b3a9f86351d57c00..24753838d28d3b5a90a39bae114c32a2446a7e67 100644

--- a/src/compiler/mips64/code-generator-mips64.cc

+++ b/src/compiler/mips64/code-generator-mips64.cc

@@ -1120,8 +1120,10 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

}

case kMips64TruncUlS: {

FPURegister scratch = kScratchDoubleReg;

+ Register result = instr->OutputCount() > 1 ? i.OutputRegister(1) : no_reg;

// TODO(plind): Fix wrong param order of Trunc_ul_s() macro-asm function.

- __ Trunc_ul_s(i.InputDoubleRegister(0), i.OutputRegister(), scratch);

+ __ Trunc_ul_s(i.InputDoubleRegister(0), i.OutputRegister(), scratch,

+ result);

break;

}

case kMips64TruncUlD: {

« no previous file with comments | « src/compiler/machine-operator.cc ('k') | src/compiler/mips64/instruction-selector-mips64.cc » ('j') | src/mips64/macro-assembler-mips64.cc » ('J')