Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 15120004: Make GrAAConvexPathRender support paths with > 64K verts. (Closed)

Created:
7 years, 7 months ago by bsalomon
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make GrAAConvexPathRender support paths with > 64K verts. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9118

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -99 lines) Patch
M gm/convexpaths.cpp View 1 2 1 chunk +19 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 5 chunks +132 lines, -98 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
7 years, 7 months ago (2013-05-13 18:40:26 UTC) #1
jvanverth1
Looks okay. Is there any reason why you went with appending counts to an array ...
7 years, 7 months ago (2013-05-13 18:57:24 UTC) #2
bsalomon
On 2013/05/13 18:57:24, JimVV wrote: > Looks okay. Is there any reason why you went ...
7 years, 7 months ago (2013-05-13 19:00:31 UTC) #3
robertphillips
lgtm? https://codereview.chromium.org/15120004/diff/4/gm/convexpaths.cpp File gm/convexpaths.cpp (right): https://codereview.chromium.org/15120004/diff/4/gm/convexpaths.cpp#newcode128 gm/convexpaths.cpp:128: fPaths.push_back().moveTo(0, 0); i = 1? https://codereview.chromium.org/15120004/diff/4/src/gpu/GrAAConvexPathRenderer.cpp File src/gpu/GrAAConvexPathRenderer.cpp ...
7 years, 7 months ago (2013-05-13 19:18:04 UTC) #4
robertphillips
make that - lgtm
7 years, 7 months ago (2013-05-13 19:18:25 UTC) #5
bsalomon
https://codereview.chromium.org/15120004/diff/4/gm/convexpaths.cpp File gm/convexpaths.cpp (right): https://codereview.chromium.org/15120004/diff/4/gm/convexpaths.cpp#newcode128 gm/convexpaths.cpp:128: fPaths.push_back().moveTo(0, 0); On 2013/05/13 19:18:05, robertphillips wrote: > i ...
7 years, 7 months ago (2013-05-13 19:26:06 UTC) #6
bsalomon
7 years, 7 months ago (2013-05-14 14:20:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r9118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698