Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1511913002: Drop [LegacyInterfaceTypeChecking] for Selection.prototype.addRange (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
yoichio, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for Selection.prototype.addRange This already throws in Firefox and IE11 when the argument is null: http://software.hixie.ch/utilities/js/live-dom-viewer/saved/3781 DOMSelection::addRange is only called from generated bindings, so the assert will hold. BUG=561338 Committed: https://crrev.com/22f68ef35ec7ad8590992913ef8733ceb9c911d3 Cr-Commit-Position: refs/heads/master@{#364322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/addRange-failures.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/addRange-failures-expected.txt View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Selection.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511913002/1
5 years ago (2015-12-09 10:32:54 UTC) #2
philipj_slow
PTAL
5 years ago (2015-12-09 12:54:34 UTC) #4
haraken
LGTM
5 years ago (2015-12-09 13:55:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511913002/1
5 years ago (2015-12-09 14:29:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/146917)
5 years ago (2015-12-09 16:07:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511913002/1
5 years ago (2015-12-09 17:48:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/147149)
5 years ago (2015-12-09 20:23:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511913002/1
5 years ago (2015-12-09 21:21:25 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/147281)
5 years ago (2015-12-10 00:01:02 UTC) #19
brucedawson
On 2015/12/10 00:01:02, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-10 01:20:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511913002/1
5 years ago (2015-12-10 08:11:35 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 09:19:27 UTC) #24
commit-bot: I haz the power
5 years ago (2015-12-10 09:20:35 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22f68ef35ec7ad8590992913ef8733ceb9c911d3
Cr-Commit-Position: refs/heads/master@{#364322}

Powered by Google App Engine
This is Rietveld 408576698