Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1511893004: [build system] Support code coverage. (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build system] Support code coverage. Committed: https://crrev.com/ce47fc8b7228c4b9c6b3b549dff7dafca05ca26d Cr-Commit-Position: refs/heads/master@{#32743}

Patch Set 1 #

Patch Set 2 : we have to go deeper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M build/standalone.gypi View 1 6 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jakob Kummerow
Replaces https://codereview.chromium.org/1297843003 and addresses the comments therein. PTAL.
5 years ago (2015-12-09 17:40:01 UTC) #2
Michael Achenbach
lgtm
5 years ago (2015-12-09 20:20:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511893004/1
5 years ago (2015-12-10 09:19:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/11239) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-10 09:20:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511893004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511893004/20001
5 years ago (2015-12-10 09:52:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 10:11:02 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-10 10:11:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce47fc8b7228c4b9c6b3b549dff7dafca05ca26d
Cr-Commit-Position: refs/heads/master@{#32743}

Powered by Google App Engine
This is Rietveld 408576698