Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1511893002: Fix Promise intrinsicDefaultProto (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Promise intrinsicDefaultProto BUG=v8:3900, v8:3931, v8:1543, v8:3330 LOG=n Committed: https://crrev.com/2d13f6ec43a717d5c27aeabd084b2338996498b3 Cr-Commit-Position: refs/heads/master@{#32731}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/harmony/reflect-construct.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
5 years ago (2015-12-09 08:46:59 UTC) #2
Igor Sheludko
lgtm
5 years ago (2015-12-09 08:59:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511893002/20001
5 years ago (2015-12-09 17:02:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/457)
5 years ago (2015-12-09 19:14:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511893002/20001
5 years ago (2015-12-09 20:55:50 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 00:33:25 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-10 00:33:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d13f6ec43a717d5c27aeabd084b2338996498b3
Cr-Commit-Position: refs/heads/master@{#32731}

Powered by Google App Engine
This is Rietveld 408576698