Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 1511883002: [turbofan] Add initial support for SOFT deopts. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add initial support for SOFT deopts. This only introduces the basic support for both SOFT and EAGER deopts in TurboFan, but doesn't make use of SOFT deopts anywhere yet (there are some other issues blocking that). Basically every Deoptimize operator now has a DeoptimizeKind, which can be either kSoft or kEager. R=jarin@chromium.org Committed: https://crrev.com/7a22fdff1ebfebcdd83f2cae488915ae8ea2dc81 Cr-Commit-Position: refs/heads/master@{#32690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -35 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/common-operator.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 4 chunks +45 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +15 lines, -8 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-09 04:54:43 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fundamental support for SOFT deopts, no functional change. Please take a ...
5 years ago (2015-12-09 05:04:17 UTC) #2
Jarin
lgtm
5 years ago (2015-12-09 06:37:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511883002/1
5 years ago (2015-12-09 06:38:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 06:53:51 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 06:54:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a22fdff1ebfebcdd83f2cae488915ae8ea2dc81
Cr-Commit-Position: refs/heads/master@{#32690}

Powered by Google App Engine
This is Rietveld 408576698