Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1511833006:
Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. (Closed)
DescriptionDocument LEAK_SANITIZER_IGNORE_OBJECT() more precisely.
R=haraken
BUG=567257
NOTRY=true
Committed: https://crrev.com/8b88951a9393d658751e9adbe068a704fb0aff0c
Cr-Commit-Position: refs/heads/master@{#365025}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Shorten comment #Messages
Total messages: 15 (7 generated)
sigbjornf@opera.com changed reviewers: + haraken@chromium.org, kcc@chromium.org, thakis@chromium.org
please take a look.
LGTM https://codereview.chromium.org/1511833006/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/wtf/LeakAnnotations.h (right): https://codereview.chromium.org/1511833006/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/wtf/LeakAnnotations.h:81: // ignored memory chunk and consider that set as ignored and unreachable. Slightly better: lsan_ignore_object(X) means that LSan ignores the object graph starting with X. It does not mean that LSan considers the objects reachable from X are unreachable.
https://codereview.chromium.org/1511833006/diff/1/third_party/WebKit/Source/w... File third_party/WebKit/Source/wtf/LeakAnnotations.h (right): https://codereview.chromium.org/1511833006/diff/1/third_party/WebKit/Source/w... third_party/WebKit/Source/wtf/LeakAnnotations.h:81: // ignored memory chunk and consider that set as ignored and unreachable. On 2015/12/11 09:46:36, haraken wrote: > > Slightly better: lsan_ignore_object(X) means that LSan ignores the object graph > starting with X. It does not mean that LSan considers the objects reachable from > X are unreachable. A bit too brief perhaps? It ignores the object at X, not its object graph.
On 2015/12/11 10:03:37, sof wrote: > https://codereview.chromium.org/1511833006/diff/1/third_party/WebKit/Source/w... > File third_party/WebKit/Source/wtf/LeakAnnotations.h (right): > > https://codereview.chromium.org/1511833006/diff/1/third_party/WebKit/Source/w... > third_party/WebKit/Source/wtf/LeakAnnotations.h:81: // ignored memory chunk and > consider that set as ignored and unreachable. > On 2015/12/11 09:46:36, haraken wrote: > > > > Slightly better: lsan_ignore_object(X) means that LSan ignores the object > graph > > starting with X. It does not mean that LSan considers the objects reachable > from > > X are unreachable. > > A bit too brief perhaps? It ignores the object at X, not its object graph. lsan_ignore_object(X) means that LSan does not trace X. It does not mean that LSan considers the objects reachable from X are unreachable. ? (It's up to you.)
Description was changed from ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R= BUG= ========== to ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R=haraken BUG=567257 ==========
Description was changed from ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R=haraken BUG=567257 ========== to ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R=haraken BUG=567257 NOTRY=true ==========
Shortened the comment, trying to balance brevity with general grokability.
The CQ bit was checked by sigbjornf@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/1511833006/#ps20001 (title: "Shorten comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511833006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511833006/20001
Message was sent while issue was closed.
Description was changed from ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R=haraken BUG=567257 NOTRY=true ========== to ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R=haraken BUG=567257 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R=haraken BUG=567257 NOTRY=true ========== to ========== Document LEAK_SANITIZER_IGNORE_OBJECT() more precisely. R=haraken BUG=567257 NOTRY=true Committed: https://crrev.com/8b88951a9393d658751e9adbe068a704fb0aff0c Cr-Commit-Position: refs/heads/master@{#365025} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8b88951a9393d658751e9adbe068a704fb0aff0c Cr-Commit-Position: refs/heads/master@{#365025} |
