Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 151183006: Set up field trial for precache experiment (Closed)

Created:
6 years, 10 months ago by bengr
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set up field trial for precache experiment By default, this trial is disabled. BUG=309216 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250821

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/precache/content/precache_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
bengr
asvitkine: everything
6 years, 10 months ago (2014-02-11 23:08:37 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/151183006/diff/1/chrome/browser/chrome_browser_field_trials_mobile.cc File chrome/browser/chrome_browser_field_trials_mobile.cc (right): https://codereview.chromium.org/151183006/diff/1/chrome/browser/chrome_browser_field_trials_mobile.cc#newcode73 chrome/browser/chrome_browser_field_trials_mobile.cc:73: void PrecacheFieldTrial() { I'm not sure this block of ...
6 years, 10 months ago (2014-02-12 15:41:49 UTC) #2
bengr
I see. It's fine if the experiment doesn't run on first run. I removed the ...
6 years, 10 months ago (2014-02-12 17:42:43 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 10 months ago (2014-02-12 17:45:48 UTC) #4
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 10 months ago (2014-02-12 18:23:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/151183006/80001
6 years, 10 months ago (2014-02-12 18:24:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 20:49:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262663
6 years, 10 months ago (2014-02-12 20:49:35 UTC) #8
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 10 months ago (2014-02-12 21:05:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/151183006/80001
6 years, 10 months ago (2014-02-12 21:06:41 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 23:04:39 UTC) #11
Message was sent while issue was closed.
Change committed as 250821

Powered by Google App Engine
This is Rietveld 408576698