attestation: Fix policy observer expiry check.

attestation: Fix policy observer expiry check.

The certificate format is now a PEM certificate chain. This code did not
get updated and was still attempting to parse DER X.509. This change
updates the code to parse PEM and auto-renewal of Enterprise Machine
Certificates should work again.

BUG=b:24618871
TEST=unit: now using fake expired certs in PEM format

Committed: https://crrev.com/7b4457e06c7b1e4f8a6b2fa1268948d8a4a2b439
Cr-Commit-Position: refs/heads/master@{#364475}

[Darren Krahn, 2015-12-10 01:32:16]

dkrahn@chromium.org changed reviewers:
+ mnissler@chromium.org

[Mattias Nissler (ping if slow), 2015-12-10 08:08:40]

LGTM w/ nit.

This going unnoticed suggests that we need better integration testing though -
does it make sense to add a browser test or autotest to exercise the refresh
logic?

https://chromiumcodereview.appspot.com/1511793004/diff/1/chrome/browser/chrom...
File chrome/browser/chromeos/attestation/attestation_policy_observer.h (right):

https://chromiumcodereview.appspot.com/1511793004/diff/1/chrome/browser/chrom...
chrome/browser/chromeos/attestation/attestation_policy_observer.h:69: void
CheckCertificateExpiry(const std::string& certificate);
nit: Please update the variable name to reflect the semantics, i.e.
|pem_certificate_chain| or somesuch.

[Darren Krahn, 2015-12-10 19:53:12]

On 2015/12/10 08:08:40, Mattias Nissler wrote:
> LGTM w/ nit.
> 
> This going unnoticed suggests that we need better integration testing though -
> does it make sense to add a browser test or autotest to exercise the refresh
> logic?

Due to the nature of the attestation system, we need to fake the cert at some
level for all these types of tests. Now that the unit test is fixed (to fake
correctly) I'm not convinced it adds a lot of value to fake the cert somewhere
else also.

> 
>
https://chromiumcodereview.appspot.com/1511793004/diff/1/chrome/browser/chrom...
> File chrome/browser/chromeos/attestation/attestation_policy_observer.h
(right):
> 
>
https://chromiumcodereview.appspot.com/1511793004/diff/1/chrome/browser/chrom...
> chrome/browser/chromeos/attestation/attestation_policy_observer.h:69: void
> CheckCertificateExpiry(const std::string& certificate);
> nit: Please update the variable name to reflect the semantics, i.e.
> |pem_certificate_chain| or somesuch.

Done

[Darren Krahn, 2015-12-10 19:54:05]

The CQ bit was checked by dkrahn@chromium.org

[Darren Krahn, 2015-12-10 19:54:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnissler@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1511793004/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2015-12-10 19:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1511793004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1511793004/20001

[commit-bot: I haz the power, 2015-12-10 21:09:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 21:11:17]

Description was changed from

==========
attestation: Fix policy observer expiry check.

The certificate format is now a PEM certificate chain. This code did not
get updated and was still attempting to parse DER X.509. This change
updates the code to parse PEM and auto-renewal of Enterprise Machine
Certificates should work again.

BUG=b:24618871
TEST=unit: now using fake expired certs in PEM format
==========

to

==========
attestation: Fix policy observer expiry check.

The certificate format is now a PEM certificate chain. This code did not
get updated and was still attempting to parse DER X.509. This change
updates the code to parse PEM and auto-renewal of Enterprise Machine
Certificates should work again.

BUG=b:24618871
TEST=unit: now using fake expired certs in PEM format

Committed: https://crrev.com/7b4457e06c7b1e4f8a6b2fa1268948d8a4a2b439
Cr-Commit-Position: refs/heads/master@{#364475}
==========

[commit-bot: I haz the power, 2015-12-10 21:11:18]

Patchset 2 (id:??) landed as
https://crrev.com/7b4457e06c7b1e4f8a6b2fa1268948d8a4a2b439
Cr-Commit-Position: refs/heads/master@{#364475}