Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1511783002: Mojo JS bindings: fix the unittests. (Closed)

Created:
5 years ago by yzshen1
Modified:
5 years ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: fix the unittests. This CL removes the build target with the old EDK and makes the one with the new EDK compile & pass. This CL also merges the run_all_unittests.cc in mojo/edk/system and mojo/edk/test. BUG=536669 TEST=mojo_js_unittests should be able to run. Committed: https://crrev.com/ba7c43fa399baec9814cb1519500a9ffa0fd774f Cr-Commit-Position: refs/heads/master@{#364098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -139 lines) Patch
M mojo/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/js/BUILD.gn View 2 chunks +1 line, -15 lines 0 comments Download
M mojo/edk/js/test/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D mojo/edk/system/run_all_unittests.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M mojo/edk/test/run_all_unittests.cc View 2 chunks +16 lines, -1 line 0 comments Download
M mojo/mojo_edk_tests.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/js/connector.js View 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/public/js/core_unittests.js View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/js/validation_unittests.js View 5 chunks +51 lines, -21 lines 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 2 chunks +0 lines, -19 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/js/test/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
5 years ago (2015-12-09 00:38:19 UTC) #2
jam
lgtm
5 years ago (2015-12-09 16:37:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511783002/1
5 years ago (2015-12-09 17:20:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 17:36:49 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-09 17:37:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba7c43fa399baec9814cb1519500a9ffa0fd774f
Cr-Commit-Position: refs/heads/master@{#364098}

Powered by Google App Engine
This is Rietveld 408576698