Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1511773009: Revert of [es6] support AssignmentPattern as LHS in for-in/of loops (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] support AssignmentPattern as LHS in for-in/of loops (patchset #9 id:280001 of https://codereview.chromium.org/1508933004/ ) Reason for revert: Hits unreachable code (found by fuzzer). Example crasher: "for(();;);" Original issue's description: > [es6] support AssignmentPattern as LHS in for-in/of loops > > BUG=v8:811, v8:4599 > LOG=N > R=adamk@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/e47bdb775564b2cd8365047425898ab4274190a6 > Cr-Commit-Position: refs/heads/master@{#32773} TBR=rossberg@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811, v8:4599 Committed: https://crrev.com/8b968b70e9319ad5ad0b2181c4d5ef3e0f03f4fa Cr-Commit-Position: refs/heads/master@{#32774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -160 lines) Patch
M src/ast/ast.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/parsing/parser.cc View 9 chunks +16 lines, -44 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +4 lines, -13 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +8 lines, -24 lines 0 comments Download
M test/mjsunit/harmony/destructuring-assignment.js View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
adamk
Created Revert of [es6] support AssignmentPattern as LHS in for-in/of loops
5 years ago (2015-12-11 01:59:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511773009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511773009/1
5 years ago (2015-12-11 01:59:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 01:59:33 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-11 02:00:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b968b70e9319ad5ad0b2181c4d5ef3e0f03f4fa
Cr-Commit-Position: refs/heads/master@{#32774}

Powered by Google App Engine
This is Rietveld 408576698